Summary: | konqueror freezes when the proxy autoconfig URL is a redirect | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Ralf Hildebrandt <ralf.hildebrandt> |
Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kontakt, malte |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.6.3 | |
Sentry Crash Report: | |||
Attachments: | The proxy.pac file |
Description
Ralf Hildebrandt
2006-03-09 22:34:16 UTC
$ wget -S http://proxy.charite.de --22:34:43-- http://proxy.charite.de/ => `index.html' Resolving proxy.charite.de... 160.45.178.69, 160.45.178.70, 192.168.220.201, ... Connecting to proxy.charite.de|160.45.178.69|:80... connected. HTTP request sent, awaiting response... HTTP/1.0 301 Go Away Connection: close Location: http://proxy.charite.de/proxy.pac Location: http://proxy.charite.de/proxy.pac [following] --22:34:43-- http://proxy.charite.de/proxy.pac => `proxy.pac' Connecting to proxy.charite.de|160.45.178.69|:80... connected. HTTP request sent, awaiting response... HTTP/1.0 200 OK Server: fnord/1.10-2 Content-Type: application/x-ns-proxy-autoconfig Content-Length: 571 Last-Modified: Thu, 09 Mar 2006 21:34:29 GMT Length: 571 [application/x-ns-proxy-autoconfig] 100%[====================================>] 571 --.--K/s 22:34:43 (25.93 MB/s) - `proxy.pac' saved [571/571] Created attachment 15032 [details]
The proxy.pac file
*** This bug has been confirmed by popular vote. *** Still there in 3.5.3 *** Bug 128267 has been marked as a duplicate of this bug. *** I think the code responsible for this behaviour can be found at kdelibs/kio/misc/kpac/downloader.cpp, in method Downloader::download(). KIO::get(url, false, false) is called there, and I suppose that KIO::get() does not follow redirects? I don't see why not, though. The http kioslave actually supports redirects perfectly. Anyone? BTW, Alt-F2 and typing in the (to be rewritten) URL works great and opens up kwrite with the proxy autoconfig script. However, Krun uses the same KIO::TransferJob *job = KIO::get( m_strURL, false /*reload*/, m_bProgressInfo ); as our code here. *sigh* Still there in 3.5.5 Git commit 32fffc6767d5f93796c804ea5528e404698a0455 by Dawit Alemayehu. Committed on 26/04/2011 at 04:06. Pushed by adawit into branch 'KDE/4.6'. On redirection, update the proxy script URL so that it avoids a catch-22: proxy url retreival require a proxy url! Fixes a long long standing bug. BUG: 123356 FIXED-IN: 4.6.3 M +9 -2 kio/misc/kpac/downloader.cpp M +1 -0 kio/misc/kpac/downloader.h http://commits.kde.org/kdelibs/32fffc6767d5f93796c804ea5528e404698a0455 Git commit 18de1f67dec3a55bfb9690930fac55996c99252f by Dawit Alemayehu. Committed on 26/04/2011 at 04:06. Pushed by adawit into branch 'master'. On redirection, update the proxy script URL so that it avoids a catch-22: proxy url retreival require a proxy url! Fixes a long long standing bug. BUG: 123356 FIXED-IN: 4.6.3 (cherry picked from commit 32fffc6767d5f93796c804ea5528e404698a0455) M +9 -2 kio/misc/kpac/downloader.cpp M +1 -0 kio/misc/kpac/downloader.h http://commits.kde.org/kdelibs/18de1f67dec3a55bfb9690930fac55996c99252f |