| Summary: | qscintilla support does not get added to libsmokeqt when --enable-qscintilla=yes is specified | ||
|---|---|---|---|
| Product: | [Unmaintained] bindings | Reporter: | Jason E. Hale <bsdkaffee> |
| Component: | general | Assignee: | bindings-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | rakuco |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | FreeBSD Ports | ||
| OS: | FreeBSD | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
why not just use --with-qscintilla ? Caleb, that would be a workaround and does not fix the problem. If it is supposed to be --with-qscintilla, then it should be changed to that so anyone looking at the configure script and all of the available configure arguments won't be misled by trying --enable-qscintilla only to find qcscintilla support was not compiled. The fact is I had to spend time trying to figure out what was going on and this is a subtle item that is easy to miss. SVN commit 517076 by rdale:
* Applied fix from Jason Hale to make the enable qscintilla build option
work
CCBUGS: 123055
M +1 -1 configure.in.in
--- branches/KDE/3.5/kdebindings/smoke/qt/configure.in.in #517075:517076
@@ -33,7 +33,7 @@
AC_ARG_ENABLE(
qscintilla,
[ --enable-qscintilla@<:@=yes|no@:>@ Smoke: build Smoke with QScintilla extention for qt @<:@default:no@:>@],
- [ qtextscintilla="$withval" ],
+ [ qtextscintilla="$enableval" ],
[ qtextscintilla="no" ]
)
AC_SUBST(qtextscintilla)
Fixed many years ago, and valid only for 3.x. Closing. |
Version: (using KDE KDE 3.5.1) Installed from: FreeBSD Ports Compiler: GCC 3.4.4 OS: FreeBSD When libsmokeqt is compiled with --enable-qscintilla=yes set, the configure option does not get recognized because $withval is used in configure.in instead of $enableval. The following is a patch for kdebindings-3.5.1/smoke/qt/configure.in.in: --- 2006-03-03-libsmokeqt-configure.in.in.diff starts here --- --- configure.in.in.orig Sat Sep 10 04:16:39 2005 +++ configure.in.in Fri Mar 3 23:46:27 2006 @@ -33,7 +33,7 @@ AC_ARG_ENABLE( qscintilla, [ --enable-qscintilla@<:@=yes|no@:>@ Smoke: build Smoke with QScintilla extention for qt @<:@default:no@:>@], - [ qtextscintilla="$withval" ], + [ qtextscintilla="$enableval" ], [ qtextscintilla="no" ] ) AC_SUBST(qtextscintilla) --- 2006-03-03-libsmokeqt-configure.in.in.diff ends here ---