Summary: | When saving an image, the suggested filename isn't always right | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Niels <niels.misc> |
Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED WORKSFORME | ||
Severity: | wishlist | CC: | bluedzins, boards, finex, hannibal |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Niels
2006-02-20 21:54:07 UTC
Probably of duplicate of #126078. kget does not respect Content-Disposition http header. *** Bug 126078 has been marked as a duplicate of this bug. *** I think this is KIO FileCopyJob problem, at least in kget situation. This class constructor take dest param witch probably cannot be change. There are two ways to fix that. First, fetch real filename before call FileCopyJob (i.e. do HEAD http request). This metchod reqire major changes in all applications causing problems. The second, write new FileCopyJob2 witch internal make HEAD request and change dest filename to this is set in Content-Disposition header. This can be security hole so KFileDialog can be called from it and user may accept/or not this new name. The best way will be integration this two classes in one (i.e. FileCopyIn or FileDownload) whitch will be fetch Headers, ask user for local filename and make download. This second metchod is more complex but also more universal and IMHO better. Konqueror 3.5.7 on Kubuntu suggests the correct file name. Either the website has changed (doubtfull) or Konqueror has. This bug should probably be closed. Konqueror seems to be working, but Bug 126078 still exists - can we sever that relationship, closing this one, and reopening that one? Testing kget directly in kde 4.1, it's even worse now. I get "invalid directory" (I'm saving to my home directory), and the suggested filename is, well, just my home directory (no file name - just directory name). Oh, and konqueror is suggesting "index.html" as the file name again. Konqueror 3.5.9 suggests the correct filename. KDE 4.4.5 - without kget integration: it saves the JPG correctly - with kget integration: kget asks for save .html (this is a known bug) Konqueror 3.5.10 gets the file name right, so that's good. However, other links and websites (eg. Demonoid) still cause problems. @Niels: Konqueror 3.5.10 is no more developed and maintained, so if you have found other problems in different websites, please check them with KDE 4 (4.4 o 4.5) and report them on a new bug report. Thanks for the collaboration! :-) |