Bug 122285

Summary:	style is applied to arrows' ends
Product:	[Applications] kig	Reporter:	Stefan Monov <logixoul>
Component:	general	Assignee:	Pino Toscano <pino>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Stefan Monov 2006-02-19 15:05:08 UTC

Version:           v0.10.5 (using KDE 3.5.1 Level "a" , SUSE 10.0 UNSUPPORTED)
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.13-15.8-default

How to reproduce:
Create a vector and set its style to something dashy, preferably the smallest dashes.
Observed behavior:
The arrow at its end becomes hard to recognize as an arrow and it's ugly.
Expected behavior:
Apply the style only to the arrow body, not to the end.

Comment 1 Pino Toscano 2006-02-19 15:24:32 UTC

SVN commit 511296 by pino:

Draw the vector arrow with a normal style.
CCBUG: 122285


 M  +4 -0      kigpainter.cpp  


--- branches/KDE/3.5/kdeedu/kig/misc/kigpainter.cpp #511295:511296
@@ -678,8 +678,12 @@
   dir /= length;
   Coordinate c = b - dir + perp;
   Coordinate d = b - dir - perp;
+  // draw the arrow lines with a normal style
+  mP.setPen( QPen( color, width == -1 ? 1 : width, Qt::SolidLine ) );
   drawSegment( b, c );
   drawSegment( b, d );
+  // setting again the original style
+  mP.setPen( QPen( color, width == -1 ? 1 : width, style ) );
 }
 
 /* *** this function is commented out ***

Comment 2 Pino Toscano 2006-02-19 15:25:05 UTC

SVN commit 511297 by pino:

Draw the vector arrow with a normal style.
CCBUG: 122285


 M  +4 -0      kigpainter.cpp  


--- branches/kig/post-kde-3.5/kig/misc/kigpainter.cpp #511296:511297
@@ -678,8 +678,12 @@
   dir /= length;
   Coordinate c = b - dir + perp;
   Coordinate d = b - dir - perp;
+  // draw the arrow lines with a normal style
+  mP.setPen( QPen( color, width == -1 ? 1 : width, Qt::SolidLine ) );
   drawSegment( b, c );
   drawSegment( b, d );
+  // setting again the original style
+  mP.setPen( QPen( color, width == -1 ? 1 : width, style ) );
 }
 
 /* *** this function is commented out ***

Comment 3 Pino Toscano 2006-02-19 15:25:37 UTC

SVN commit 511298 by pino:

Draw the vector arrow with a normal style.
BUG: 122285


 M  +4 -0      kigpainter.cpp  


--- trunk/KDE/kdeedu/kig/misc/kigpainter.cpp #511297:511298
@@ -673,8 +673,12 @@
   dir /= length;
   Coordinate c = b - dir + perp;
   Coordinate d = b - dir - perp;
+  // draw the arrow lines with a normal style
+  mP.setPen( QPen( color, width == -1 ? 1 : width, Qt::SolidLine ) );
   drawSegment( b, c );
   drawSegment( b, d );
+  // setting again the original style
+  mP.setPen( QPen( color, width == -1 ? 1 : width, style ) );
 }
 
 /* *** this function is commented out ***

Comment 4 Stefan Monov 2006-02-19 15:30:23 UTC

OK, I know what I'm gonna write now is totally irrelevant and unimportant and a complete waste of time, but goddamn it, I can't help myself.

Oh-My-God-Wow-This-Was-Totally-Amazingly-Fast. 19 minutes. I expected months. I bow before you.

Comment 5 Carsten Niehaus 2006-02-19 15:39:37 UTC

We developers need more such totally irrelevant comments :)