Summary: | Text selection when searching not properly updating selection start/end position | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Stuart Bingë <skbinge> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bluedzins |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Stuart Bingë
2006-02-16 14:45:19 UTC
SVN commit 560302 by kling: Synchronize the "cached" selection when exposing a search match. This makes it possible to modify the new selection. BUG: 122101 M +1 -0 katesearch.cpp M +6 -0 kateview.cpp M +2 -0 kateview.h --- branches/KDE/3.5/kdelibs/kate/part/katesearch.cpp #560301:560302 @@ -736,6 +736,7 @@ { view()->setCursorPositionInternal ( cursor.line(), cursor.col() + slen, 1 ); view()->setSelection( cursor.line(), cursor.col(), cursor.line(), cursor.col() + slen ); + view()->syncSelectionCache(); } //END KateSearch --- branches/KDE/3.5/kdelibs/kate/part/kateview.cpp #560301:560302 @@ -1373,6 +1373,12 @@ return setSelection( KateTextCursor(startLine, startCol), KateTextCursor(endLine, endCol) ); } +void KateView::syncSelectionCache() +{ + m_viewInternal->selStartCached = selectStart; + m_viewInternal->selEndCached = selectEnd; +} + bool KateView::clearSelection() { return clearSelection(true); --- branches/KDE/3.5/kdelibs/kate/part/kateview.h #560301:560302 @@ -238,6 +238,8 @@ void selectLine( const KateTextCursor& cursor ); void selectLength( const KateTextCursor& cursor, int length ); + void syncSelectionCache(); + // // KTextEditor::BlockSelectionInterface stuff // Bug is still there, KDE 3.5.7. Please reopen. |