| Summary: | Toggle of Tab setting "show close button on tabs instead of website icon" is not applied | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Christian D. <christiand59> |
| Component: | tabbing | Assignee: | Konqueror Developers <konq-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bluedzins, groszdanielpub, lex.lists |
| Priority: | NOR | ||
| Version: | 3.5 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8.1 | |
| Sentry Crash Report: | |||
|
Description
Christian D.
2006-02-11 21:23:52 UTC
It should read: You need to kill all _preloaded_ konqueror instances It needs a strings change from "Show close buttons on tabs" to "Show close buttons on tabs. Needs Konqueror restart". It can not have the "Needs Konqueror restart", as it will not follow KDE UIG. http://developer.kde.org/documentation/standards/kde/style/basics/settings.html The settings should take immediate effect in all application instances! The option's tooltip ([...]"instead of websites' icons") is inapropriate in recent versions where the close buton is not placed instead of the icon. (Is this worth a separate report?) Git commit 3a35ba14e62e3f9bceb0698802bb78f37ad8ec5f by Burkhard Lück. Committed on 23/08/2011 at 06:14. Pushed by lueck into branch 'master'. fix wrong tooltips for PermanentCloseButton+MiddleClickClose CCBUG:121792 REVIEW:101936 M +2 -2 konqueror/settings/konqhtml/advancedTabOptions.ui http://commits.kde.org/kde-baseapps/3a35ba14e62e3f9bceb0698802bb78f37ad8ec5f Git commit 2f63fe74e513580879cde3d4678d8268bd91da52 by Dawit Alemayehu. Committed on 29/01/2012 at 07:09. Pushed by adawit into branch 'KDE/4.8'. Make sure the user's preference to show or hide the close buttons takes effect as soon as the changes are applied. Not after restarting Konqueror. FIXED-IN: 4.8.1 GUI: Removed portion of a tool tip text that is no longer valid. M +1 -1 konqueror/settings/konqhtml/advancedTabOptions.ui M +1 -0 konqueror/src/konqviewmanager.cpp http://commits.kde.org/kde-baseapps/2f63fe74e513580879cde3d4678d8268bd91da52 Git commit e828d4e693ef9d3648de808be10901cf04a840b7 by Dawit Alemayehu. Committed on 29/01/2012 at 07:09. Pushed by adawit into branch 'master'. Make sure the user's preference to show or hide the close buttons takes effect as soon as the changes are applied. Not after restarting Konqueror. FIXED-IN: 4.8.1 GUI: Removed portion of a tool tip text that is no longer valid. (cherry picked from commit 2f63fe74e513580879cde3d4678d8268bd91da52) M +1 -1 konqueror/settings/konqhtml/advancedTabOptions.ui M +1 -0 konqueror/src/konqviewmanager.cpp http://commits.kde.org/kde-baseapps/e828d4e693ef9d3648de808be10901cf04a840b7 |