Bug 121647

Summary:	patch to add cdda (audio cd digital audio) support to xine engine
Product:	[Applications] amarok	Reporter:	Alberto Griggio <alberto.griggio>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	oil777
Priority:	NOR
Version:	1.3.8
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch to add audiocd playback to xine-engine patch adapted to amarok 1.4svn

Description Alberto Griggio 2006-02-09 14:48:36 UTC

Version:           1.3.8 (using KDE KDE 3.5.0)
Installed from:    Slackware Packages

Here is a patch that adds audio cd playback support to the xine backend of amarok. I've tried to minimize changes and to comment them as much as possible... I hope you will find it useful... for me it works quite well (it can play audio cds even if the cdrom drive is not attached to the soundcard, and has cddb support as well - all thanks to xine)

Comment 1 Alberto Griggio 2006-02-09 14:50:13 UTC

Created attachment 14620 [details]
patch to add audiocd playback to xine-engine

Comment 2 Mark Kretschmann 2006-02-09 16:00:04 UTC

Sorry, Alberto, the patch does not apply cleanly to amaroK 1.4. Too much has changed :( amaroK 1.3 is feature frozen, so it's useless for 1.3.

Could you check out 1.4 from SVN, and adapt the patch?

Comment 3 Alberto Griggio 2006-02-09 16:22:12 UTC

> Sorry, Alberto, the patch does not apply cleanly to amaroK 1.4. Too much has changed :( amaroK 1.3 is feature frozen, so it's useless for 1.3.
>
> Could you check out 1.4 from SVN, and adapt the patch?


I'll try to do my best...

Cheers,
Alberto

Comment 4 Alberto Griggio 2006-02-10 12:52:51 UTC

Created attachment 14627 [details]
patch adapted to amarok 1.4svn

Here you are, I adapted it and it seems to work now for the 1.4svn (checkout of
yesterday)

Comment 5 Mark Kretschmann 2006-02-10 14:31:15 UTC

SVN commit 507922 by markey:

AudioCD (CDDA) support for xine-engine, including CDDB lookup. Patch by 
Alberto Griggio <alberto.griggio@gmail.com>.

Many thanks, Alberto, this seems to work well :)

FEATURE: 121647



 M  +2 -0      ChangeLog  
 M  +47 -0     src/app.cpp  
 M  +15 -0     src/collectiondb.cpp  
 M  +24 -0     src/engine/enginebase.h  
 M  +5 -0      src/engine/xine/xine-config.cpp  
 M  +65 -1     src/engine/xine/xine-engine.cpp  
 M  +4 -0      src/engine/xine/xine-engine.h  
 M  +117 -1    src/engine/xine/xineconfigbase.ui  
 M  +11 -4     src/playlistwindow.cpp

Comment 6 Ian Monroe 2006-02-10 19:20:50 UTC

Just looking at the patch, it looks good. Another legitimate longtime user-gripe is now solved in 1.4.

Comment 7 Alberto Griggio 2006-02-12 12:02:52 UTC

Well, thanks :-) 
Next step would be to implement it for other engines as well: I think that it can be done for gstreamer without too much effort, and I'll try to when I find some time (no promise though...)

Comment 8 Ken Bloom 2006-05-26 06:21:35 UTC

This still does not work for me in 1.4. It recognizes the CD, and can tell me all of the tracks (and get CDDB) but can't play anything.

The cdplay command can play the cd though.

Comment 9 Ken Bloom 2006-05-31 15:29:24 UTC

This works for me now in 1.4. I'm guessing it was some brokenness in Debian's libasound2 1.0.11-5 (http://bugs.debian.org/369040) or 1.0.11-6 (http://bugs.debian.org/369412)