Bug 121087

Summary:	support for keymaps with variants is completely broken
Product:	[Unmaintained] kxkb	Reporter:	Ingo Klöcker <kloecker>
Component:	general	Assignee:	Andriy Rysin <arysin>
Status:	RESOLVED FIXED
Severity:	major	CC:	dgp85, gerhardk, rdieter
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	fix broken xx_XX layouts for kxkb in 3.5.1

Description Ingo Klöcker 2006-01-31 11:42:11 UTC

Version:           unknown (using KDE 3.5.0 Level "a" , SUSE 9.3 UNSUPPORTED)
Compiler:          gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)
OS:                Linux (i686) release 2.6.11.4-21.10-default

Revision 493418 completely breaks support for variants of keymaps. Only keymaps like "us" and "de" do still work, but keymaps like "en_US", "de_CH" and all other variants do no longer work. This is IMO a showstopper because it makes kxkb completely unusable for anybody who needs to use a variant. The trivial fix is reverting to revision 493417.

Comment 1 Ingo Klöcker 2006-01-31 11:43:51 UTC

Changed severity to "major" because obviously this is "a wrong program behaviour that cannot be worked around".

Comment 2 Ingo Klöcker 2006-01-31 11:45:21 UTC

Since this is probably not clear from the report: This bug was introduce after KDE 3.5.0 and will be in KDE 3.5.1 unless the change is reverted (or fixed).

Comment 3 Stephan Kulow 2006-01-31 12:07:06 UTC

too late for 3.5.1 unfortunately.

Comment 4 Diego Elio Pettenò 2006-01-31 12:08:26 UTC

Can you be more detailed in which way "it doesn't work" ?
I've tested it with both 6.8.99.15 (last monolithic I had) and currently running 7.0, and I'm actually not finding any keymap called en_US or de_CH anyway.
The problem can't be with '_' character because I used it with us_intl fine (that's what I was using on monolithic).

Comment 5 Andriy Rysin 2006-02-01 07:53:17 UTC

I can confirm this bug, Diego.
If XFree is used (not Xorg) there are layouts with underscores. I am using Xorg 6.9.0 but was easily able to reproduce it by adding de_CH layout to rules file and symbols directory.
Basically we cut out everybody who's not using Xorg 6.9.0 or older or have underscore in layout name.
I believe the last comming made on Jan 02 (to add switching layout/variants) broke it. I'd call it pretty big regression and would vote for a fix or to reverse the changes.
Please take a look.

Comment 6 Ingo Klöcker 2006-02-01 14:38:40 UTC

FWIW, I'm using Xorg 6.8.2 (on SUSE 9.3). /etc/X11/xkb/symbols/de_CH is part of the xorg-x11-6.8.2-30 RPM.

And "it doesn't work" means that kxkb shows "err" and tells me that the keymap could not be loaded.

Comment 7 Andriy Rysin 2006-02-02 05:00:44 UTC

Created attachment 14490 [details]
fix broken xx_XX layouts for kxkb in 3.5.1

This patch should fix xx_XX layouts in kxkb which were broken in 3.5.1.

Comment 8 Andriy Rysin 2006-02-02 05:02:21 UTC

Ingo could you please test this patch to see if it helps. If it does I'll send it to kde-packager@kde.org to include it in standard packages.

Comment 9 Ingo Klöcker 2006-02-04 11:37:59 UTC

I can confirm that this patch fixes the bug. Thanks a lot!

Comment 10 Rex Dieter 2006-02-11 12:44:08 UTC

*** Bug 121745 has been marked as a duplicate of this bug. ***