| Summary: | Gwenview shouldn't open multi-page tiff files | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | Ismail Donmez <ismail> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | agateau, amantia, aspotashev, contramuffin, hamboy95, jman012345, myriam, nate, oded, ogimoj, pastas4, ramos.kieran |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Multi page tiff file
Multipage tiff support missing files from the previous patch Updated patch (fixes some printing issues and a crash when quickly switching between TIFF files). |
||
|
Description
Ismail Donmez
2006-01-23 16:40:35 UTC
Created attachment 14359 [details]
Multi page tiff file
still a bug in KDE 3.5.8 > still a bug in KDE 3.5.8
Why should this be a bug of KDE?
I would say this is still a bug in GwenView 1.4.2!
I will work on it soon. I do not think it is a good idea to add support for multi-page tiff files to Gwenview. Okular already handles these kind of files and is more adapted to multi-page documents. (In reply to comment #5) > I do not think it is a good idea to add support for multi-page tiff files to > Gwenview. Okular already handles these kind of files and is more adapted to > multi-page documents. > If gwenview isn't to display additional pages, it should at least notify user that additional pages are present but can not be viewed. Gwenview is the default image viewer for tiff files in many cases, and that second page might be important. I implemented the feature for the KDE 3.5 version as it was requested to do so by a customer of our company. I will attach the diff for review later, as it has problems reading LZW compressed files (libkfaximage limitation, trying to fix that). I don't expect to be accepted, nor to be ported to KDE4 as it is, because libkfaximage is also unported. Created attachment 27544 [details]
Multipage tiff support
I attached a patch that implement multipage tiff support for gwenview for those that need it. Its only dependency is libtiff, that most users should already have installed. Loading/viewing/printing should work, saving saves the current page only. Navigation is done by Ctrl-PageUp/Ctrl-PageDown, the toolbar icons or the menu items inside View. Aurelien, in case you think it is acceptable to have this in the kde3 version (or even adapted to KDE4) I can do it, otherwise it has to live as an external patch, applied by those who need it. Tested with Gwenview from branches/extragear/kde3/graphics/gwenview and KDE3 from the latest KDE3 branch. Thanks for attaching the patch Andreas, but since I do not work on Gwenview 1.4 anymore, except for serious bug fixes, I do not think it makes sense to apply it. I am not sure what to do regarding KDE4. For this reason, I asked for other people opinions on kde-core-devel: http://lists.kde.org/?l=kde-core-devel&m=122406118222411&w=2 Created attachment 27895 [details]
missing files from the previous patch
No problem, I just put it here (now also the files needed to really compile it) in case somebody wants this feature under KDE 3.x. :) Created attachment 35391 [details]
Updated patch (fixes some printing issues and a crash when quickly switching between TIFF files).
I uploaded a modified version with some fixes. Aurelien, would you mind if I'd commit this to the kde3 branch of gwenview? (In reply to comment #14) > I uploaded a modified version with some fixes. Aurelien, would you mind if I'd > commit this to the kde3 branch of gwenview? No problem, please go ahead. Just don't expect a release :) Gwenview does not support multipage tiffs in KDE 4.7.4 and Gwenview 2.7.4. Is this considered a bug, or could it be moved to wishlist? Moved to wishlist Still an issue in Gwenview 4.10.4. But I agree with comment #5 and comment #6 in that it would be nicer if Gwenview could launch Okular in order to to view multipage TIFFs instead. Yeah, Gwenview *shouldn't* support multi-page TIFFs; they should open in Okular instead. I would like to add to this bug report because when Gwenview tries to load multi-page tiffs that are very large (say 2 GB) it causes Gwenview to freeze while waiting on disk I/O. Despite that Gwenview loads the entire 2 GB file and of course consumes 2 GB of memory at least momentarily, it only displays the first image in the multi-page file. So I believe if Gwenview were to continue supporting multi-page tiffs it should only load one page at a time into memory and it should have a separate slider to view other pages. I think it would be beneficial for Gwenview to have an option in the settings like "Show videos" to disable showing of multi-page tiffs or even all tiffs. I strongly disagree with Gwenview not supporting multi-page TIFF files. These are image files and Gwenview is an image viewer; it should support viewing the entire file. Further, Okular is a document viewer, so it makes no sense to have an image file format rely on it. I have several sets of mixed TIFF and multi-TIFF pictures, and I view them by opening one in Gwenview and using the forward and back arrows to navigate through the pictures in a directory. Having to alternate between Gwenview and Okular would be (and currently is) incredibly unwieldy. Ideally I'd like to see Gwenview implement something like Windows Explorer does, where a forward and back arrow appear below the picture but above the bottom toolbar when a multi-page TIFF file is opened to enable browsing through pages. *** Bug 497529 has been marked as a duplicate of this bug. *** |