Bug 120629

Summary: Added file xorg-composite.conf does not appear in Project Files
Product: [Unmaintained] quanta Reporter: michael papet <mpapet>
Component: generalAssignee: András Manţia <amantia>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 3.5   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description michael papet 2006-01-23 05:29:17 UTC
Version:           3.5 (using KDE 3.5.0 Level "a" , SUSE 9.3 UNSUPPORTED)
Compiler:          gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)
OS:                Linux (i686) release 2.6.11.4-20a-default

Hi,

Here are the steps to reproduce the bug.

1. Project>Insert Files  Browse to xorg-composite.conf and select okay.
2. File does not appear in Project Files, no error generated.

I've added other conf files without a problem.

Let me know if I need to send something else along.
Comment 1 András Manţia 2006-01-23 08:58:47 UTC
Where can I find this xorg-composite.conf file?
Comment 2 András Manţia 2006-01-23 10:05:02 UTC
If I create a file with that name, I can add to the project and it 
appears there. What is the "Exclude from project" line in Project 
Properties? Do you have read/search access to that file?
Comment 3 michael papet 2006-01-24 04:45:11 UTC
I re-ran the steps to produce the bug and found I didn't provide enough information.

File Locations:
/home/myusername (my user folder)
/home/myusername/website (folder keeps all web files & subfolders)
/home/myusername/website/linux (folder holds linux-specific pages)

Procedures:
I click on the linux folder on the file tree and open something in the folder.
Project>Insert Files and browse to linux folder, select file.
Hit "OK" and the file adds to the file tree just fine.  That is the reply you sent me and it works as expected.

Project>Insert Files and browse back to /home/myusername to select a file, any file.
Hit "OK" and the file fails to appear in the project file tree.  No error message either.  It copies itself into the folder of my project, but does not appear in the project.  I checked the directory contents and verify that it's copying.  Maybe I'm wrongly assuming that I should be able to select a user file from anywhere in my home folder?  

Project>Insert Files and browse back to /home/myusername/website to select a file, any file.
Hit "OK" and the file fails to appear in the project file tree.  No error message either.    
Comment 4 András Manţia 2006-01-26 21:46:49 UTC
SVN commit 502648 by amantia:

I have no idea how we missed it and since when it is in this state... Fixes insertion of files to the project using the Project menu.
BUG: 120629

 M  +1 -0      ChangeLog  
 M  +14 -14    project/projectprivate.cpp  


--- branches/KDE/3.5/kdewebdev/quanta/ChangeLog #502647:502648
@@ -3,6 +3,7 @@
 Version 3.5.2 (Release date: xx-02-2006; Started 23-01-2005):
  - bugfixes:
         - allow opening of read-only remote files, like from http:// [#120632]
+        - fix insertion of files to the project [#120629]
 
 Version 3.5.1 (Release date: 23-01-2006; Started 30-11-2005):
  - bugfixes:
--- branches/KDE/3.5/kdewebdev/quanta/project/projectprivate.cpp #502647:502648
@@ -1431,7 +1431,7 @@
         CopyTo *dlg = new CopyTo( baseURL);
         connect(dlg, SIGNAL(deleteDialog(CopyTo*)),
                     SLOT  (slotDeleteCopytoDlg(CopyTo*)));
-        connect(dlg, SIGNAL(addFilesToProject(const KURL::List&)),
+        connect(dlg, SIGNAL(addFilesToProject(const KURL::List&)), parent,
                     SLOT  (slotInsertFilesAfterCopying(const KURL::List&)));
         list = dlg->copy( list, destination );
         return;
@@ -1441,17 +1441,17 @@
       }
     }
 
-  insertFiles( list );
-  //Take care also of the selected dirs
-  KURL dirURL;
-  for (uint i = 0; i < list.count(); i++)
-  {
-    dirURL = list[i];
-    if (dirURL.path().endsWith("/"))
+    insertFiles( list );
+    //Take care also of the selected dirs
+    KURL dirURL;
+    for (uint i = 0; i < list.count(); i++)
     {
-      insertFiles( dirURL, "*" );
+      dirURL = list[i];
+      if (dirURL.path().endsWith("/"))
+      {
+        insertFiles( dirURL, "*" );
+      }
     }
-  }
 
     parent->reloadTree( &(m_projectFiles), false, QStringList());
   }
@@ -1467,10 +1467,10 @@
 
 void ProjectPrivate::slotAddDirectory()
 {
-KURL url = KURL();
-url = KFileDialog::getExistingURL(baseURL.prettyURL(), m_mainWindow,
-                i18n("Insert Folder in Project"));
-parent->slotAddDirectory(url);
+  KURL url = KURL();
+  url = KFileDialog::getExistingURL(baseURL.prettyURL(), m_mainWindow,
+                  i18n("Insert Folder in Project"));
+  parent->slotAddDirectory(url);
 }