Bug 120503

Summary:	form buttons do not receive keyboard focus
Product:	[Applications] konqueror	Reporter:	Luciano Montanaro <mikelima>
Component:	khtml forms	Assignee:	Maksim Orlovich <maksim>
Status:	RESOLVED FIXED
Severity:	normal	CC:	maksim, yan
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	an html snippet that shows the problem patch woops, fix

Description Luciano Montanaro 2006-01-20 12:04:34 UTC

Version:            (using KDE KDE 3.5.0)
Installed from:    Unspecified

a <button> element in a form cannot be selected using the tab key.
Check with the attached test page:
pressing tab multiple times skips over the button element, to land on the following input box.

The equivalent <input type="button"> works correctly.
The form works as I expected to with Firefox.

Comment 1 Luciano Montanaro 2006-01-20 12:05:57 UTC

Created attachment 14313 [details]
an html snippet that shows the problem

Comment 2 Maksim Orlovich 2006-01-20 15:47:15 UTC

Created attachment 14316 [details]
patch

here you go, this ought to fix it. Will commit once branch reopened for 3.5.2

Comment 3 Luciano Montanaro 2006-01-20 15:51:44 UTC

On Friday 20 January 2006 15:47, Maksim Orlovich wrote:
[bugs.kde.org quoted mail]

Hey! You acted too fast, I was hoping to have a look about it during the 
weekend. :)
Well, thank you very much, I'll go trekking instead.

Comment 4 Maksim Orlovich 2006-01-20 16:22:08 UTC

Created attachment 14318 [details]
woops, fix

looks like I lost a case when breaking up the conjuction

Comment 5 Maksim Orlovich 2006-01-20 16:27:53 UTC

Please ignore the parts of the 2nd diff that don't involve html_formimpl.cpp :-)

Comment 6 Maksim Orlovich 2006-01-20 16:46:34 UTC

*** Bug 120511 has been marked as a duplicate of this bug. ***

Comment 7 Maksim Orlovich 2006-01-26 15:32:56 UTC

I committed this (accidentally) with my kb events work... at any rate, fixed for 3.5.2

Comment 8 Mitch 74 2006-05-17 17:00:24 UTC

the button can be selected with the keyboard under 3.5.2 (that's better), but it stays inactive when pressed (using space or CR to 'press' the button will change its appearance but it won't activate; this may not be related to KHTML or Konqueror, as I'm having similar problems with UI buttons).