| Summary: | smart rotation (first keystroke 90°, second keystroke 180°) | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Kusi <test> |
| Component: | Plugin-Bqm-Rotate | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 5.0.0 | |
| Sentry Crash Report: | |||
|
Description
Kusi
2006-01-20 11:30:52 UTC
thats a wish not a bug, sorry Are you talking about image editor or albums view ? Gilles Caulier hmm, somehow this sounds complicated. How do you imaging that this should work? Like a keyboard double klick and keyboard single klick? Or if image is already in landscape then rotate in by 180 degrees? Is there a real advantage compared to pressing 3 times a 'rotate by 90 degree' shortcut? Maybe the 'rotate by whatever' action could be optimized to abort an ongoing rotation (or only start an rotation after an the double click timeout is over) and starting a new rotation that sums up both rotate actions into a new one? I'm not convienced yet ;) -- Only IMHO of course Achim Fully agree with you Achim. It can be complicated to drive. There are more urgent tasks to do before this one (:=)))... Gilles Achim, Just to give you a technical response to your question, to do what Kusi want, we can use a QTimer witch can be re-started during delay (500ms is a good value). The user press at one to a keyboard shorcut, the timer is started. If timer is out of delay (500ms), a signal is send to rotate the image to 90°. If the user press another one to the keyboard shorcut, the timer is restarted to delay 500ms anymore without send a rotation event util the end of delay... and again, and again... Gilles I was thinking of the same behavior as iPhoto (maybe it was not iPhoto, can't remember) on MacOSX. Consider the following use cases when you need rotation 1) the image has an angle of 90° -> rotate it to 0° by pressing R 2) the image has an angle of 270° -> rotate it to 0° by pressing L 3) the image had an angle of 90° and you rotated it into the wrong direction by pressing L (be honest to yourself, that happens:) The image now is upside down in each of the cases 90 & 270° -> press L again (within the timeframe as Gilles suggested) and the image is rotated 180° and you're all set. 4) the image has an angle of 180° -> WTF, you're taking pictures upside down?! That only happens when you're completely wasted:) Especially in case 3), the suggested shortcuts brings an advantage. Since I assume nobody wants to rotate an image by 180°, in case 3) after pressing L, the next desired action (if any) has to be most likey a rotation by 180° and not another 90°. Kusi Kusi, But, are you talking about image editor or albums view (thrue JPEGLossLess kipi-plugins) ? Gilles I'm talking about the JPEGLossLess plugin in album-view. In my personal opinion, the rendering/loading of IE is still too slow, therefore I don't use IE for image preparation. I think, IE is not made for quick and simple image processing but for time consuming image impromements. Therefore I dont't think it's necessary to implement this in IE. PS: on a sidenote, Gilles, I'm the guy who was talking about the slideshow plugin on IRC. Sorry I don't have much time for digikam right now, hopefully that will change. I already implemented threaded image preloading and texture downloading to GPU for several preloaded images. It's already much more useable than the existing slideshow, but not yet ready to showcase. Ok, I toogle this file to kipi-plugins group. Kusi, let's me hear your progress about SlideShow kipi-plugin. It important to have a feedback reguliary from developper to prevent duplicate works during long stand bye period. Thanks in advance Gilles Kusi, What's news about this file ? Gilles Caulier Kusi, This file still valid using kipi-plugins 2.4 ? Gilles Caulier New Kipiplugins 4.11.0 is available : https://www.digikam.org/node/740 Can you reproduce the problem with this release ? Gilles Caulier JPEGLossLess tool is not maintained and now obsolete with 5.0.0 |