Bug 120309

Summary: change screen backgroundcolor of image tools
Product: [Applications] digikam Reporter: Daniel Bauer <linux>
Component: ImageEditor-CanvasAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In: 0.9.4
Sentry Crash Report:
Attachments: gradation.png
BCG tool with red background color in preview area
digikam_back3.jpg
digikam_back1.png
digikam_back2.png
digikam_back3.png

Description Daniel Bauer 2006-01-17 14:57:11 UTC
Version:           0.8.0 (using KDE KDE 3.5.0)
Installed from:    SuSE RPMs
Compiler:          gcc 

I like the "dark" design of digikam. When clicking on a thumbnail the background of the window is dark then, too. But when using a manipulation tool (like e.g. "gradation"), I have a bright grey window background.

When you work a lot with photos, this change from dark to bright hurts the eyes, and, more important, it makes it almost impossible to work consistently with colours (colours, of course appear different to the human eye when the surrounding colours change).

So I have a simple wish: can you make it possible to somehow change the background color (window color) of the tools, too? Or even align the style of the tools with the chosen design automatically?

B.t.w.: I am professional photographer and I consider digikam a great helper!

regards
Daniel
Comment 1 caulier.gilles 2006-01-17 15:02:19 UTC
Hi,

ok. I understand what's you want. I will take a look how to implement this feature in next release 0.9.0.

Question : what's "Gradation" tool ? (:=)))

Gilles Caulier
Comment 2 Daniel Bauer 2006-01-17 15:23:48 UTC
> ok. I understand what's you want. I will take a look how to implement this
> feature in next release 0.9.0.
>
> Question : what's "Gradation" tool ? (:=)))
>
> Gilles Caulier


Thanks a lot!

Did I spell something wrong? You're the developper of the gradation tool, I 
can proof it, see attachement :-) 

Daniel Bauer


Created an attachment (id=14286)
gradation.png
Comment 3 Thorsten Schnebeck 2006-01-17 15:35:00 UTC
> Question : what's "Gradation" tool ? (:=)))


Hehe :-) Olivers translation is in some points more correct and 
professional than the original ;-)

http://dict.leo.org/?search=gradation
http://de.wikipedia.org/wiki/Gradation
http://de.wikipedia.org/wiki/Dichte_(Fotografie)#Die_Gradationskurve_in_der_digitalen_Bildbearbeitung

Bye

  Thorsten
Comment 4 caulier.gilles 2006-01-17 15:46:57 UTC
Excelent. This is a very nice digiKam screenshot !!!

If you is a pro-photographer, please take a look in current 0.9.0 alpha implementation availalble in svn...

There is any screenshots available here : 

http://digikam3rdparty.free.fr/Screenshots/

and especially the new "Gradation" tool witch support RAW file images in 16 bits :

http://digikam3rdparty.free.fr/Screenshots/digikam0.9.0-alpha2.png

Gilles Caulier
Comment 5 Daniel Bauer 2006-01-18 08:50:33 UTC
> If you is a pro-photographer, please take a look in current 0.9.0 alpha
> implementation availalble in svn...
>
> There is any screenshots available here :
>
> http://digikam3rdparty.free.fr/Screenshots/
>
> and especially the new "Gradation" tool witch support RAW file images in 16
> bits :
>
> http://digikam3rdparty.free.fr/Screenshots/digikam0.9.0-alpha2.png
>
> Gilles Caulier


Wow, this looks fantastic! 
But - as I am just a user (and surely not the most skilled one...) - I am 
always a bit afraid of using pre-releases. So I guess, I'll wait for the 
final (called "stable"?) version of the next release. Since I've seen here 
what will come with it, I almost can't wait... 

Daniel
Comment 6 caulier.gilles 2006-03-21 08:36:05 UTC
Created attachment 15230 [details]
BCG tool with red background color in preview area
Comment 7 caulier.gilles 2006-03-21 08:36:30 UTC
Daniel, here we are a screenshot of the BCG dialog tool where i have forced to red the color of the background widget used to render the image preview effect.

Is this color that you want to set like you want ? If yes, i can put a toogle option in digiKam setup dialog to use the Image Editor background color here, or not...

Gilles
Comment 8 Daniel Bauer 2006-03-21 10:15:58 UTC
Am Dienstag, 21. März 2006 08:36 schrieb Gilles Caulier:
[bugs.kde.org quoted mail]

Good morning Gilles

No, it's not exactly what I was thingking about. I prepared some samples that 
I attach to show my idea:

digikam_back1.png : 
The album view, using "design: dark" (I like this design, it's very 
beautiful!)

I click on the picture and get the view shown in 
digikam_back2.png
background has the same properties as album view (here: dark)

Then I correct the curves:
digikam_back3.png: 
the background is gray now

I'd like to have the _whole_ background applied acording to the "design" as 
shown in 
digikam_back3.jpg 
(sorry, just fast work as a sample...)

If you use quickview and switch between digikam_back3.png and 
digikam_back3.jpg you can see that the impression of colours changes very 
much due to the bright background or vice-versa, it hurts the eyes and makes 
it hard to get a consistent colour feeling... 

Even if the background just around the picture changes (as shown in your 
preview)  there still remains a lot of bright gray that changes the colour 
impression.

My idea was, just to apply the "design" the user chooses in the 
digiKam-setting to all further windows, too. Don't know, if this is 
possible...

regards

Daniel


Created an attachment (id=15231)
digikam_back3.jpg

Created an attachment (id=15232)
digikam_back1.png

Created an attachment (id=15233)
digikam_back2.png

Created an attachment (id=15234)
digikam_back3.png
Comment 9 Manuel Amador (Rudd-O) 2006-03-23 22:12:58 UTC
Can I have the entire set of pictures from the latest attachments?

Those look really nice.
Comment 10 Manuel Amador (Rudd-O) 2006-03-23 22:13:20 UTC
:-)

(I was NOT kidding)
Comment 11 Daniel Bauer 2006-03-24 10:31:21 UTC
Am Donnerstag, 23. März 2006 22:12 schrieb Manuel Amador:
[bugs.kde.org quoted mail]

> ------- Additional Comments From rudd-o amautacorp com  2006-03-23 22:12
> ------- Can I have the entire set of pictures from the latest attachments?
>
> Those look really nice.


Hi Manuel

Thanks for your comments on my photos - they were published by accident only, 
I wanted to answer to the digikam developper Gilles directly and not to the 
bugs page... ;-)

The shown photos are actually in work and will be published later on my 
website http://www.bauer-nudes.com . At the moment I don't know when this 
will be - it always takes longer than I think. So just have a look into the 
page once in a while or enter to the mail list on the page, if you want to be 
informed about updates... 

regards

Daniel
Comment 12 caulier.gilles 2006-04-03 15:36:39 UTC
Daniel, your screenshots sounds like a theme usability into image editor at all. It's can be long to do. I delayed this features later 0.9.0.

Gilles Caulier
Comment 13 Mikolaj Machowski 2007-11-21 21:15:02 UTC
I agree with Daniel. Not only very valid point about perception of colors but also small problem with usability: with all lightgray background sometimes it is hard to see when hover effect will kick in.

It doesn't have - even shouldn't be - configurable separately. It should be always the same color as background of Image Editor.
Comment 14 caulier.gilles 2008-03-05 14:40:53 UTC
Daniel,

Please take a look in this digikam-devel mailing list entry:

http://article.gmane.org/gmane.comp.kde.digikam.devel/20880

... and let's me hear your viewpoint

Gilles Caulier
Comment 15 caulier.gilles 2008-03-05 21:25:16 UTC
SVN commit 782714 by cgilles:

digiKam from KDE3 branch : full color scheme theme support everywhere in interface "à la Amarok" (albumgui, lighttable, camera interface, editor, image plugins and kipi-plugins)
A demo is available here: http://digikam3rdparty.free.fr/Screenshots/fullcolorschemesupport-desserttheme.png
CCMAIL: digikam-devel@kde.org
BUG: 120309
TODO: KDE4PORT


 M  +2 -11     digikam/albumiconview.cpp  
 M  +0 -14     digikam/folderview.cpp  
 M  +2 -100    libs/imageproperties/cameraitempropertiestab.cpp  
 M  +1 -2      libs/imageproperties/cameraitempropertiestab.h  
 M  +6 -21     libs/imageproperties/imagepropertiessidebarcamgui.cpp  
 M  +1 -2      libs/imageproperties/imagepropertiessidebarcamgui.h  
 M  +1 -14     libs/imageproperties/imagepropertiessidebardb.cpp  
 M  +1 -2      libs/imageproperties/imagepropertiessidebardb.h  
 M  +1 -109    libs/imageproperties/imagepropertiestab.cpp  
 M  +1 -2      libs/imageproperties/imagepropertiestab.h  
 M  +6 -5      libs/themeengine/theme.h  
 M  +92 -49    libs/themeengine/themeengine.cpp  
 M  +6 -6      libs/themeengine/themeengine.h  
 M  +25 -36    themedesigner/mainwindow.cpp  
 M  +1 -2      themedesigner/mainwindow.h  
 M  +1 -9      themedesigner/themediconview.cpp  
 M  +1 -11     utilities/cameragui/cameraiconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=782714
Comment 16 caulier.gilles 2008-03-05 22:20:47 UTC
SVN commit 782732 by cgilles:

backport commit #782714 from KDE3 branch
CCBUGS: 120309


 M  +0 -16     digikam/albumiconview.cpp  
 M  +0 -33     digikam/folderview.cpp  
 M  +0 -55     libs/imageproperties/cameraitempropertiestab.cpp  
 M  +0 -1      libs/imageproperties/cameraitempropertiestab.h  
 M  +0 -13     libs/imageproperties/imagepropertiessidebarcamgui.cpp  
 M  +0 -1      libs/imageproperties/imagepropertiessidebarcamgui.h  
 M  +0 -13     libs/imageproperties/imagepropertiessidebardb.cpp  
 M  +0 -1      libs/imageproperties/imagepropertiessidebardb.h  
 M  +0 -63     libs/imageproperties/imagepropertiestab.cpp  
 M  +0 -1      libs/imageproperties/imagepropertiestab.h  
 M  +1 -0      libs/themeengine/theme.cpp  
 M  +1 -0      libs/themeengine/theme.h  
 M  +72 -7     libs/themeengine/themeengine.cpp  
 M  +1 -1      libs/themeengine/themeengine.h  
 M  +1 -11     themedesigner/mainwindow.cpp  
 M  +1 -2      themedesigner/mainwindow.h  
 M  +1 -0      themedesigner/themediconitem.h  
 M  +1 -10     themedesigner/themediconview.cpp  
 M  +2 -11     utilities/cameragui/cameraiconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=782732
Comment 17 Daniel Bauer 2008-03-06 08:50:07 UTC
Hi Gilles,

looks great! I'm sure it will help a lot because color-impression then remains the same no matter what portion of digikam you use.

Hope it will soon be in the stable version, so I can enjoy it, too :-)

Daniel   
Comment 18 caulier.gilles 2008-03-14 10:20:43 UTC
SVN commit 785523 by cgilles:

digiKam from KDE3 branch : Showfoto now support Color Theme scheme as digiKam core

CCBUGS: 120309
CCMAIL: digikam-devel@kde.org



 M  +2 -0      showfoto/Makefile.am  
 M  +25 -4     showfoto/setup/setupeditor.cpp  
 M  +5 -1      showfoto/setup/setupeditor.h  
 M  +14 -5     showfoto/showfoto.cpp  
 M  +2 -1      showfoto/showfotoui.rc  
 M  +40 -0     utilities/imageeditor/editor/editorwindow.cpp  
 M  +6 -0      utilities/imageeditor/editor/editorwindow.h  
 M  +3 -35     utilities/imageeditor/editor/imagewindow.cpp  
 M  +0 -2      utilities/imageeditor/editor/imagewindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=785523