Bug 120276

Summary: tagging groups of files causes amarok to become unresponsive for long periods
Product: [Applications] amarok Reporter: djandruczyk
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.3.8   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description djandruczyk 2006-01-17 01:29:54 UTC 
Version:           1.3.8 (using KDE KDE 3.4.3)
Installed from:    Gentoo Packages
Compiler:          gcc version 3.4.4 (Gentoo 3.4.4-r1, ssp-3.4.4-1.0, pie-8.7.8)
OS:                Linux

While attempting to retag files that were mis-tagged during a CD rip (the initial incorrect tags are NOT amarok's fault) I'm finding it to take exhoribitant mounts of time to retag groups of files.  Typically on the order or about 1 file per second. (which stinks if you try and retag a batch of 300 or so)  The method I'm using is to view my Collection and highlight a group of files that are in the wrong artist and click on "Edit information for XXX tracks"  Enter the proper information and tell it to go.  I tried a test of about 661 files (audiobooks that were mistagged under the wrong artist), and it takes about 7 minutes for this to complete,during this time audio stopped playing and amarok's gui frooze and failed to redran anything. (perhaps the retag should run as a thread as it doesn't need to do anything to the gui at all)

Now here's the strange part.  If I edit the tags for a group of files and make a mistake and have to redo it,  the second time takes probably 1/20th the time and disk activity is much higher.  Perhaps it's because things are now cached in RAM (I have 2.5GB of ram, not your typical end user machine).

The collection database engine is sqlite.
Comment 1 richlv 2006-07-17 15:25:50 UTC 
this is slightly better with mysql, though multiple file operations still freeze the gui and prohibit advancing to the next track (svn 563210)
Comment 2 Alexandre Oliveira 2006-07-25 19:35:49 UTC 
SVN commit 566280 by aoliveira:

"Some" work on tagdialog:
- Now we have statistics tab enabled when in multiple tags mode. Information there is pretty much a stub, I gotta improve that;
- It's now possible to edit scores/ratings for multiple tracks;
- Tag writing is done in a thread;
- Some clean up here and there, cutting some member variables we don't need anymore;
And of course, new bugs and regressions! Enjoy.
BUG: 130593
BUG: 120276



 M  +7 -6      collectiondb.cpp  
 M  +2 -1      playlist.cpp  
 M  +160 -62   tagdialog.cpp  
 M  +1 -6      tagdialog.h