Bug 120159

Summary:	Use color scheme's text color for tab bar, or make it configurable
Product:	[Applications] konversation	Reporter:	Gábor Lehel <illissius>
Component:	general	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Gábor Lehel 2006-01-15 11:50:16 UTC

Version:            (using KDE KDE 3.5.0)
Installed from:    Compiled From Sources

The color for highlighting in the tab bar has thankfully been made configurable -- I would like to request that in its default, unhighlighted state, to have it use the color for text defined by KDE's color scheme, instead of hardcoding it black. (This is because I happen to use a black background; black on black is not the most readable of combinations.)
Or make it configurable along with the rest of the highlight colors, if you swing that way.

Comment 1 Eike Hein 2006-01-15 11:59:56 UTC

I'll make it use the text color.

Comment 2 Eike Hein 2006-01-15 12:44:48 UTC

SVN commit 498296 by hein:

* Use color scheme "Standard Text" colour as tab text
  default colour, consistent with Konqueror and Kopete.
* Pick up global colour palette changes accordingly.
BUG:120159


 M  +1 -3      konversationapplication.cpp  
 M  +2 -2      konversationmainwindow.cpp  


--- trunk/extragear/network/konversation/src/konversationapplication.cpp #498295:498296
@@ -125,6 +125,7 @@
         connect(this, SIGNAL(prefsChanged()), mainWindow, SIGNAL(prefsChanged()) );
         // take care of user style changes, setting back colors and stuff
         connect(KApplication::kApplication(), SIGNAL(appearanceChanged()), mainWindow, SLOT(updateAppearance()));
+        connect(KApplication::kApplication(), SIGNAL(appearanceChanged()), mainWindow, SLOT(updateTabNotifications()));
 
         // apply GUI settings
         mainWindow->updateAppearance();
@@ -910,10 +911,7 @@
     emit prefsChanged();
 
     if(updateGUI)
-    {
-        mainWindow->updateAppearance();
         emit appearanceChanged();
-    }
 }
 
 void KonversationApplication::updateNickIcons()
--- trunk/extragear/network/konversation/src/konversationmainwindow.cpp #498295:498296
@@ -1058,7 +1058,7 @@
         }
     }
 
-    getViewContainer()->setTabColor(view, QColor());
+    getViewContainer()->setTabColor(view, colorGroup().text());
 }
 
 void KonversationMainWindow::updateTabNotifications()
@@ -1092,7 +1092,7 @@
         for(int i = 0; i < viewContainer->count(); ++i)
         {
             ChatWindow* view = static_cast<ChatWindow*>(viewContainer->page(i));
-            getViewContainer()->setTabColor(view, QColor());
+            getViewContainer()->setTabColor(view, colorGroup().text());
         }
     }

Comment 3 Gábor Lehel 2006-01-15 13:01:51 UTC

Wow, that was fast :)

Comment 4 Eike Hein 2006-01-15 13:10:24 UTC

I actually used the wrong colour first (what I did was consistent with Konqueror and Kopete but, the correct colour to use here is the foreground rather than the text color - evil Konq! :), so there's a check-in after this that improves on it. Also another small corner case fix for dynamically picking up global colour palette changes. Enjoy!