Bug 119741

Summary: wish list - restore image editor if already open
Product: [Applications] digikam Reporter: Ted Hansen <tedhansen>
Component: Usability-ErgonomyAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version: 0.8.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 0.9.0

Description Ted Hansen 2006-01-08 16:28:05 UTC 
Version:           0.8.0 (using KDE 3.5.0, Debian Package 4:3.5.0-1 (testing/unstable))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.13-kanotix-9

Clicking on a thumbnail opens the image editor but if it is already open and is minimized nothing happens. 
Please have the open click action open the image editor if it is not open but restore it and update to the current image if it is open but has been minimized.
Thanks.
Comment 1 Marcel Wiesweg 2006-04-24 20:27:40 UTC 
SVN commit 533407 by mwiesweg:

Deiconify image editor window in loadURL when it is minimized

BUG: 119741



 M  +1 -0      NEWS  
 M  +1 -2      TODO  
 M  +9 -2      utilities/imageeditor/editor/imagewindow.cpp  


--- trunk/extragear/graphics/digikam/NEWS #533406:533407
@@ -121,5 +121,6 @@
 ==> 117225 (digikam requires at least libpng >= 1.2.7)
 ==> 115423 (thumbnails view jumps to top when new photos are added)
 ==> 125732 (ICC settings get reset when disabled and re-enabled)
+==> 119741 (Image Editor: restore image editor if already open)
 
 ----------------------------------------------------------------------------------------------------
--- trunk/extragear/graphics/digikam/TODO #533406:533407
@@ -51,10 +51,9 @@
 ==> 93569   (CameraGUI: easier connection to USB disc cameras)
 ==> 125696  (CameraGUI: digikam does not connect to USB camera with libgphoto-2.1.99)
 ==> 121367  (Add properties tab to digiKam and (especially) IE)
-==> 114241  (Main Interface: image comments encoding unreadable after moving an album)
+==> 114211  (Main Interface: image comments encoding unreadable after moving an album)
 ==> 120241  (Main Interface: utf8 display and edit)
 ==> 118501  (Image Editor:   Exif lost when modifying the images)
-==> 119741  (Image Editor:   restore image editor if already open)
 ==> 116148  (Image Editor:   auto-scrolling when selecting large area)
 ==> 111446  (Image Editor:   bad behaviour when out of disk space)
 ==> 122374  (Image Editor:   ignores read-only permission during saving)
--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp #533406:533407
@@ -56,6 +56,7 @@
 #include <kstatusbar.h>
 #include <kpopupmenu.h>
 #include <kprogress.h>
+#include <kwin.h>
 
 // Local includes.
 
@@ -269,16 +270,22 @@
 void ImageWindow::loadURL(const KURL::List& urlList, const KURL& urlCurrent,
                           const QString& caption, bool allowSaving, AlbumIconView* view)
 {
+    // if window is iconified, show it
+    if (isMinimized())
+    {
+        KWin::deIconifyWindow(winId());
+    }
+
     if (!promptUserSave(m_urlCurrent))
         return;
-    
+
     setCaption(i18n("digiKam Image Editor - %1").arg(caption));
 
     m_view        = view;
     m_urlList     = urlList;
     m_urlCurrent  = urlCurrent;
     m_allowSaving = allowSaving;
-    
+
     m_saveAction->setEnabled(false);
     m_revertAction->setEnabled(false);
     m_undoAction->setEnabled(false);