Bug 119562

Created attachment 14141 [details]
add support for the Sylpheed-Claws mua

SVN commit 495347 by toma:

Adds support for the Sylpheed-Claws mua. Based on a patch from Paul Mangan. I modified the patch to prevent code duplication. Can you verify if this solution works as well? Thanks dor the patch.
BUG: 119562


 M  +8 -3      sendimages.cpp  
 M  +2 -0      sendimagesdialog.cpp  


--- trunk/extragear/libs/kipi-plugins/sendimages/sendimages.cpp #495346:495347
@@ -344,12 +344,17 @@
 
     // Sylpheed mail agent call.
 
-    if ( m_sendImagesDialog->m_mailAgentName->currentText() == "Sylpheed" )
+    if ( m_sendImagesDialog->m_mailAgentName->currentText() == "Sylpheed" ||
+         m_sendImagesDialog->m_mailAgentName->currentText() == "Sylpheed-Claws" )
     {
         m_mailAgentProc = new KProcess;
-        *m_mailAgentProc << "sylpheed" << "--compose";
-        *m_mailAgentProc << "--attach";
+        if ( m_sendImagesDialog->m_mailAgentName->currentText() == "Sylpheed")
+            *m_mailAgentProc << "sylpheed";
+        else
+            *m_mailAgentProc << "sylpheed-claws";
 
+        *m_mailAgentProc << "--compose" << "--attach";
+
         for ( KURL::List::Iterator it = m_filesSendList.begin() ; it != m_filesSendList.end() ; ++it )
             *m_mailAgentProc << QFile::encodeName((*it).path());
 
--- trunk/extragear/libs/kipi-plugins/sendimages/sendimagesdialog.cpp #495346:495347
@@ -360,6 +360,7 @@
     m_mailAgentName->insertItem( "Mozilla" );
     m_mailAgentName->insertItem( "Netscape" );
     m_mailAgentName->insertItem( "Sylpheed" );
+    m_mailAgentName->insertItem( "Sylpheed-Claws" );
     m_mailAgentName->insertItem( "Thunderbird" );
     m_mailAgentName->setCurrentText( "Kmail" );
     QWhatsThis::add( m_mailAgentName, i18n("<p>Select here your preferred external mail agent program."
@@ -371,6 +372,7 @@
                                            "<b>Mozilla</b>: >= 1.4<p>"
                                            "<b>Netscape</b>: >= 7.x<p>"
                                            "<b>Sylpheed</b>: >= 0.9<p>"
+                                           "<b>Sylpheed-Claws</b>: >= 0.9<p>"
                                            "<b>Thunderbird</b>: >= 0.4<p>") );
 
     hlay10->addWidget( m_mailAgentLabel );

I have verified that it works. Thanks!

On Saturday 07 January 2006 21:34, Tom Albers wrote:
> Adds support for the Sylpheed-Claws mua. Based on a patch from Paul Mangan.
> I modified the patch to prevent code duplication. Can you verify if this
> solution works as well? Thanks dor the patch.


I dont understand why you do not use the KDE tools for this. 
KApplication::invokeMailer() uses the mail client configured by the user in 
the KDE component chooser.

-anders

invokeMailer has an option to add an attachment, but every app seems to have a different sytax to launch the app if necessary and open the composer. For Thunderbird invokeMailer does not seem to work as expected (opening a composer with file attached).

Well, it would be smarter if that was fixed in kapplication then, otherwise 
the method should really be removed...