Bug 119560

The bug is also in KDE 3.5.1

Also present in 3.5.2

(OS: Linux, Distribution: Archlinux, Package: Official distribution packages)

This looks like 800x600 and less resolution specific ? I just went through the code... and heres what it says..
*line 101*

    if (desk.width() <= 800)
    {
        m_settings->setPreview(false);
    }


I changed my monitor res to 1024x786 (very horrible refresh rates here 15"monitor..pls dont laugh..i'm stuck with it. heh) and previews were on. Previews look great on 800x600.. I wonder what made the devs add that forced check. Is it possible for Aaron to change that 800 to.. say 640 ? 8)

I'm sure that changing it to something less than 800 will do the job.. but gonna recompile and make sure.

Forgot to mention the file name. Its kdebase-3.5.3/kicker/applets/minipager/pagerapplet.cpp

Yep, thats it. I recompiled with that modification and it works. Hope the forced preview disabling will be removed/modified.

Created attachment 17093 [details]
possible fix?

could you please try the attached (untested) patch? i can't test it right now
against 3.5 and would like to have this fix in for 3.5.x. it's a bit of a hack,
but it should set the default to false, preserving the default as false but
allowing the user to override it. thanks =)

SVN commit 565544 by aseigo:

allow manually turning on of previews in the pager at low screen
resolutions
thanks to vinay shastry for testing the patch.
BUG:119560


 M  +10 -7     pagerapplet.cpp  


--- branches/KDE/3.5/kdebase/kicker/applets/minipager/pagerapplet.cpp #565543:565544
@@ -87,6 +87,16 @@
       m_contextMenu(0),
       m_settings( new PagerSettings(sharedConfig()) )
 {
+    int scnum = QApplication::desktop()->screenNumber(this);
+    QRect desk = QApplication::desktop()->screenGeometry(scnum);
+    if (desk.width() <= 800)
+    {
+        KConfigSkeleton::ItemInt* item = dynamic_cast<KConfigSkeleton::ItemBool*>(m_settings->findItem("Preview"));
+        if (item)
+        {
+            item->setDefaultValue(false);
+        }
+    }
     m_settings->readConfig();
     m_windows.setAutoDelete(true);
     TaskManager::the()->trackGeometry();
@@ -96,13 +106,6 @@
 
     setFont( KGlobalSettings::taskbarFont() );
 
-    int scnum = QApplication::desktop()->screenNumber(this);
-    QRect desk = QApplication::desktop()->screenGeometry(scnum);
-    if (desk.width() <= 800)
-    {
-        m_settings->setPreview(false);
-    }
-
     m_kwin = new KWinModule(this);
     m_activeWindow = m_kwin->activeWindow();
     m_curDesk = m_kwin->currentDesktop();