Bug 119415

Summary:	background wallpaper downloader doesn't escape "/"
Product:	[Unmaintained] kdelibs	Reporter:	Zachary Jensen <coolguyzak>
Component:	knewstuff	Assignee:	Jeremy Whiting <jpwhiting>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andresbajotierra, finex, gladhorn, nameczanin
Priority:	NOR
Version First Reported In:	3.5
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Zachary Jensen 2006-01-02 19:34:52 UTC

Version:            (using KDE KDE 3.5.0)
Installed from:    Debian testing/unstable Packages
OS:                Linux

I was using the "Get New Wallpapers" functionality in KDE 3.5. I chose to download a picture known as "/dev/urandom/" (Link: http://www.kde-look.org/content/show.php?content=202 ). When the get new wallpapers dialog saved the picture, it saved it as "~/.kde/share/wallpapers/dev/urandom--0" instead of "~/.kde/share/wallapers/dev\/urandom--0" (Note the escaped slash).

I noticed other bug reports that specified that "newstuff" wasn't saving file extensions as well. While that seems not to matter with my version of KDE, I did notice that KDE was not saving it with the same filename specified on kde-look, "202-devurandom.jpg".

Because I do not know the rationale of the decision to save by title, I am submitting this bug report with the un-escaped slash description. If it turns out that the problem is that it is not saving it by the proper filename, then feel free to switch it.

Comment 1 Jakub Stachowski 2009-01-05 16:04:17 UTC

*** Bug 164836 has been marked as a duplicate of this bug. ***

Comment 2 Dario Andres 2009-06-02 14:59:41 UTC

Just checked here using:

Qt: 4.5.1 (qt-copy  971295)
KDE: 4.2.88 (KDE 4.2.88 (KDE 4.3 >= 20090527))
kdelibs svn rev. 975695 / kdebase svn rev. 975695
on ArchLinux i686 - Kernel 2.6.29.4

The "/dev/urandom" wallpaper (http://www.kde-look.org/content/show.php?content=202) real file name (on server) is "202-devurandom.jpg" (as you can see in the server page: http://www.kde-look.org/CONTENT/content-files/202-devurandom.jpg)

After downloaded that wallpaper with GHNS (sort by "Most downloaded" search for "random"), the entry "~/.kde4/share/wallpapers/202-devurandom.jpg"

So, the filename of the file in the server is preserved (and it is also the extension)

I don't know if previously the filename on server contained slashes. Now it does not.

Would you expect the filename of the file being the Name of the wallpaper (and therefor to contain slashes) ?

Thanks

Comment 3 Frederik Gladhorn 2010-03-23 11:26:27 UTC

The real file name from the server is now used without path, so this should no longer cause trouble.
I consider this fixed.
Greetings,
Frederik