Bug 118840

Summary: Duplicate 'Pages' tab when change 'type' in "configure DTEP" menu to xml more than once
Product: [Unmaintained] quanta Reporter: Chris Dary <umbrae>
Component: generalAssignee: András Manţia <amantia>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 3.4.2   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Chris Dary 2005-12-22 05:22:10 UTC 
Version:           3.4.2 (using KDE KDE 3.5.0)
Installed from:    SuSE RPMs
OS:                Linux

From DTD->Edit DTD Settings, pick a DTD, and change its type to 'XML', then click the type selectbox again, and click 'XML' again. Two 'Pages' tabs will show up.
Comment 1 Chris Dary 2005-12-22 05:25:15 UTC 
KDE is actually version 3.4.2 I believe, not 3.5.0
Comment 2 András Manţia 2005-12-23 10:30:43 UTC 
SVN commit 490803 by amantia:

Don't show the Pages tab in DTEP editing dialog more than once.
BUG: 118840

 M  +1 -0      ChangeLog  
 M  +3 -2      dialogs/dtepeditdlg.cpp  


--- branches/KDE/3.5/kdewebdev/quanta/ChangeLog #490802:490803
@@ -7,6 +7,7 @@
         - crash fixes in VPL [#118686]
         - don't loose the comment closing character when formatting the XML code [#118453]
         - insert valid img tag for XHTML documents [#118805]
+        - don't show the Pages tab in DTEP editing dialog more than once [#118840]
 
 Version 3.5 (Release date: 29-11-2005; Started 04-03-2004):
  - bugfixes:
--- branches/KDE/3.5/kdewebdev/quanta/dialogs/dtepeditdlg.cpp #490802:490803
@@ -58,11 +58,12 @@
 
 void DTEPEditDlg::slotFamilyChanged(int family)
 {
-  m_family = family;
-  if (m_family == 0)
+  if (family == 0 && m_family != 0)
     tabWidget->insertTab(m_pagesWidget, i18n("&Pages"), 1);
   else
+  if (family == 1)
    tabWidget->removePage(m_pagesWidget);
+  m_family = family;
 }
 
 void DTEPEditDlg::init()