| Summary: | Problematic characters break feed parsing | ||
|---|---|---|---|
| Product: | [Applications] akregator | Reporter: | Pau Capdevila <pau.capdevila> |
| Component: | general | Assignee: | kdepim bugs <pim-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 1.2 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Pau Capdevila
2005-12-21 14:27:26 UTC
Try feedvalidator.org, this feed is not valid. - It doesn't list the items in the <channel> section. - It contains bad characters. - Values in rdf:about must be unique, but there dupes in the feeds. This is a degree of brokeness we will not support in Akregator. Go tell racocatala.com how broken their feed is. Oh...Sorry for the annoyance, I didn't knew that validator. I only validated through http://www.w3.org/RDF/Validator/ And passed. Thanks for the fast response and for Akregator, and sorry again. I tried not post the bug suddenly. friendly, Kapde 21 Dec 2005 16:21:12 -0000, Frank Osterfeld <frank.osterfeld@kdemail.net>: [bugs.kde.org quoted mail] Oh...Sorry for the annoyance,<br><br>I didn't knew that validator. I only validated through <br><br><font size="-1"><font color="#008000"><span dir="ltr"><a href="http://www.w3.org/RDF/Validator/">http://www.w3.org/RDF/Validator/ </a></span></font></font><br><br>And passed.<br><br>Thanks for the fast response and for Akregator, and sorry again. I tried not post the bug suddenly.<br><br>friendly,<br><br>Kapde<br><br><div><span class="gmail_quote">21 Dec 2005 16:21:12 -0000, Frank Osterfeld < <a href="mailto:frank.osterfeld@kdemail.net">frank.osterfeld@kdemail.net</a>>:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">------- You are receiving this mail because: ------- <br>You reported the bug, or are watching the reporter.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=118793">http://bugs.kde.org/show_bug.cgi?id=118793</a><br>frank.osterfeld kdemail net changed:<br><br> What |Removed |Added <br>----------------------------------------------------------------------------<br> Status|UNCONFIRMED |RESOLVED<br> Resolution| |WONTFIX<br><br><br><br>------- Additional Comments From frank.osterfeld kdemail net 2005-12-21 17:21 -------<br>Try <a href="http://feedvalidator.org">feedvalidator.org</a>, this feed is not valid.<br><br>- It doesn't list the items in the <channel> section.<br>- It contains bad characters. <br>- Values in rdf:about must be unique, but there dupes in the feeds.<br><br>This is a degree of brokeness we will not support in Akregator. Go tell <a href="http://racocatala.com">racocatala.com</a> how broken their feed is. <br></blockquote></div><br> It has been fixed now: "This is a valid RSS feed." says. ->Now it works in Firefox too. But still has encoding problems... ->Your feed appears to be encoded as "iso-8859-1", but your server is reporting "US-ASCII" Do you still don't support this degree of brokeness? Thank you. SVN commit 504290 by osterfeld:
RSS parser: ignore unknown or invalid version attribute value in the <rss> tag and
just assume RSS 2.0. The older formats are compatible to 2.0, so this should work.
(at least better than refusing to parse the feeds)
BUG: 118793
M +9 -0 ChangeLog
M +2 -1 src/librss/document.cpp
--- branches/KDE/3.5/kdepim/akregator/ChangeLog #504289:504290
@@ -2,6 +2,15 @@
===================
(c) 2004-2006 the Akregator authors.
+Changes after 1.2.1:
+-----------------------------
+
+Bug fixes:
+
+ 2006/01/31 RSS parser: ignore unknown or invalid version attribute value in the <rss> tag and
+ just assume RSS 2.0. The older formats are compatible to 2.0, so this should work.
+ (at least better than refusing to parse the feeds) (#118793) -fo
+
Changes after 1.2:
-----------------------------
--- branches/KDE/3.5/kdepim/akregator/src/librss/document.cpp #504289:504290
@@ -110,7 +110,8 @@
d->version = v0_93;
else if (attr == QString::fromLatin1("0.94"))
d->version = v0_94;
- else if (attr.startsWith("2.0") || attr == QString::fromLatin1("2")) // http://www.breuls.org/rss puts 2.00 in version (BR #0000016)
+ else // otherwise, we just assume a RSS2 compatible feed. As rss2 is generally
+ // backward-compatible, this should work
d->version = v2_0;
}
I really admire you. I hope one day I'll be half a programmer as you. Thank you very much indeed! Pau On 31 Jan 2006 17:05:54 -0000, Frank Osterfeld <frank.osterfeld@kdemail.net> wrote: [bugs.kde.org quoted mail] I really admire you.<br><br>I hope one day I'll be half a programmer as you.<br><br>Thank you very much indeed!<br><br>Pau<br><br><div><span class="gmail_quote">On 31 Jan 2006 17:05:54 -0000, <b class="gmail_sendername">Frank Osterfeld </b> <<a href="mailto:frank.osterfeld@kdemail.net">frank.osterfeld@kdemail.net</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> ------- You are receiving this mail because: -------<br>You reported the bug, or are watching the reporter.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=118793">http://bugs.kde.org/show_bug.cgi?id=118793</a><br>frank.osterfeld kdemail net changed:<br><br> What |Removed |Added<br>----------------------------------------------------------------------------<br> Status|UNCONFIRMED |RESOLVED <br> Resolution| |FIXED<br><br><br><br>------- Additional Comments From frank.osterfeld kdemail net 2006-01-31 18:05 -------<br>SVN commit 504290 by osterfeld:<br><br>RSS parser: ignore unknown or invalid version attribute value in the <rss> tag and <br>just assume RSS 2.0. The older formats are compatible to 2.0, so this should work.<br>(at least better than refusing to parse the feeds)<br>BUG: 118793<br><br><br><br> M +9 -0 ChangeLog<br> M +2 -1 src/librss/document.cpp <br><br><br>--- branches/KDE/3.5/kdepim/akregator/ChangeLog #504289:504290<br> @ -2,6 +2,15 @<br> ===================<br> (c) 2004-2006 the Akregator authors.<br><br>+Changes after 1.2.1:<br>+----------------------------- <br>+<br>+Bug fixes:<br>+<br>+ 2006/01/31 RSS parser: ignore unknown or invalid version attribute value in the <rss> tag and<br>+ just assume RSS 2.0. The older formats are compatible to 2.0, so this should work. <br>+ (at least better than refusing to parse the feeds) (#118793) -fo<br>+<br> Changes after 1.2:<br> -----------------------------<br><br>--- branches/KDE/3.5/kdepim/akregator/src/librss/document.cpp #504289:504290 <br> @ -110,7 +110,8 @<br> d->version = v0_93;<br> else if (attr == QString::fromLatin1("0.94"))<br> d->version = v0_94;<br>- else if (attr.startsWith("2.0") || attr == QString::fromLatin1("2")) // <a href="http://www.breuls.org/rss">http://www.breuls.org/rss</a> puts 2.00 in version (BR #0000016)<br>+ else // otherwise, we just assume a RSS2 compatible feed. As rss2 is generally<br>+ // backward-compatible, this should work <br> d->version = v2_0;<br> }<br></blockquote></div><br> |