Bug 118683

Summary: Borders on ViewImages don't print
Product: [Applications] kst Reporter: Netterfield <netterfield>
Component: generalAssignee: kst
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 1.x   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Netterfield 2005-12-20 04:52:58 UTC 
Version:           1.2.0_devel (using KDE 3.4.2 Level "b" , SUSE 10.0)
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.13-15.7-default

Create ViewImage from the toolbar
In layout mode, give it a border.  It has a border on the screen.  Print it out.  Now it doesn't.

It should.
Comment 1 George Staikos 2005-12-20 05:22:58 UTC 
SVN commit 489906 by staikos:

make images print properly again
BUG: 118683


 M  +8 -8      kstviewpicture.cpp  


--- trunk/extragear/graphics/kst/kst/kstviewpicture.cpp #489905:489906
@@ -69,14 +69,14 @@
 
 void KstViewPicture::paint(KstPainter& p, const QRegion& bounds) {
   p.save();
-  if (p.type() != KstPainter::P_PRINT && p.type() != KstPainter::P_EXPORT) {
-    if (p.makingMask()) {
-      p.setRasterOp(Qt::SetROP);
-      KstBorderedViewObject::paint(p, bounds);
-    } else {
+  if (p.makingMask()) {
+    p.setRasterOp(Qt::SetROP);
+    KstBorderedViewObject::paint(p, bounds);
+  } else {
+    KstBorderedViewObject::paint(p, bounds);
+    // FIXME: inefficient
+    if (p.type() != KstPainter::P_PRINT && p.type() != KstPainter::P_EXPORT) {
       QRegion boundary = bounds & _lastClipRegion;
-      KstBorderedViewObject::paint(p, bounds);
-      // FIXME: inefficient
       for (KstViewObjectList::Iterator i = _children.begin(); i != _children.end(); ++i) {
         boundary -= (*i)->clipRegion();
       }
@@ -84,7 +84,7 @@
       p.setClipRegion(boundary);
     }
   }
-  
+
   if (_image.isNull()) {
     QRect r(_geom);
     r.setWidth(_geom.width() - 1);