| Summary: | "Tools->Format XML Code" action formats XML comments incorrectly | ||
|---|---|---|---|
| Product: | [Unmaintained] quanta | Reporter: | Marte Soliza <myrtactle> |
| Component: | general | Assignee: | András Manţia <amantia> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nbsahara |
| Priority: | NOR | ||
| Version: | 3.5 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
SVN commit 490355 by amantia:
Don't loose the comment closing character when formatting the XML code.
BUG: 118453
M +1 -0 ChangeLog
M +6 -1 parts/kafka/wkafkapart.cpp
--- branches/KDE/3.5/kdewebdev/quanta/ChangeLog #490354:490355
@@ -5,6 +5,7 @@
- better handling of quotation marks when editing tags inside a script area [#118693]
- don't show the file changed dialog after using save as and save again
- crash fixes in VPL [#118686]
+ - don't loose the comment closing character when formatting the XML code [#118453]
Version 3.5 (Release date: 29-11-2005; Started 04-03-2004):
- bugfixes:
--- branches/KDE/3.5/kdewebdev/quanta/parts/kafka/wkafkapart.cpp #490354:490355
@@ -1081,7 +1081,12 @@
text = ">";
}
else
- text = "<" + QuantaCommon::tagCase(node->tag->name) + ">";
+ {
+ if (node->tag->tagStr() == "-->")
+ text = "-->";
+ else
+ text = "<" + QuantaCommon::tagCase(node->tag->name) + ">";
+ }
bCol += text.length();
eCol = bCol - 1;
eLine = bLine;
|
Version: 3.5 (using KDE 3.5.0, Kubuntu Package 4:3.5.0-0ubuntu0breezy1 breezy) Compiler: Target: i486-linux-gnu OS: Linux (i686) release 2.6.12-8-386 I edited an HTML file. This file have XML comments and when I click "Tools->Format XML Code", it does not format comments correctly. To be exact, here's an example: Original: <!-- hello --> <p>hello</p> "Formatted": <!-- hello <> <p>hello</p> As far as I can notice, the ending comment tag ("-->") is always misformatted as "<>". My simple workaround for this is after I format, I'll just replace all "<>" by "-->" since no valid tag such as "<>".