| Summary: | kdf shows some entries twice | ||
|---|---|---|---|
| Product: | [Applications] kdf | Reporter: | Olivier Trichet <nive> |
| Component: | general | Assignee: | Unassigned bugs <unassigned-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ab.kde, ana, bugzilla, ecjbosu, javier.conti, kde, nive, oleg.atamanenko+kde, SchaduwBlink |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Image proof of what I mean.
Screenshot |
||
|
Description
Olivier Trichet
2005-12-11 17:35:11 UTC
Maybe this is similar: Since I updated to KDE 3.5.6 and a 2.6.20 kernel using UUIDs to identify/mount partitions the partition list in kdf has doubled its size, all UUID entries have "classic" twins (/dev/hdx) when the partition is mounted. That's very confusing especially because the UUID entry shows a size of "N/A" and appears as not mounted whereas the classic entry shows a filesystem type of "?" but mounted. Does not look very reliable. Created attachment 21772 [details]
Image proof of what I mean.
Can someone take this bug out of "UNCONFIRMED" status and put it in open?
I attached an image of this. Basically, I use LABEL=Foo in my fstab and
KDiskFree should match up the LABEL with the actual disk dev name. Display
something like LABEL=Root (/dev/hda5) ext3 Size .... so on. Basically, show the
LABEL and then actual dev name in one line instead of two and calling one
unmounted. :S This bug has been open for two years now, so can someone get some
action going on this, by at least taking it out of UNCONFIRMED? That screenshot
I have pretty much confirms it and so does the 20 or so votes.
I can confirm this bug with KDE 4.0.1. (KDF 0.5) Attachment with kde 4.0.1 - http://bugs.kde.org/attachment.cgi?id=23512&action=view Also still present in KDE 3.5.9 (Mandriva 2008.1) Created attachment 25070 [details]
Screenshot
Add attachment with screenshot of BUG.
*** Bug 173082 has been marked as a duplicate of this bug. *** This is also a problem in Version 4.1.3 (KDE 4.1.3) Redhat EL5 and the version of KDE from their repositories did not have this problem. (In reply to comment #7) > This is also a problem in Version 4.1.3 (KDE 4.1.3) Running Fedora 10 > > Redhat EL5 and the version of KDE from their repositories did not have this > problem. > i done a patch to handle UUID=, can someone tell me if i can commit it on trunk ?
Index: kdf/disklist.cpp
===================================================================
--- kdf/disklist.cpp (révision 1031780)
+++ kdf/disklist.cpp (copie de travail)
@@ -28,6 +28,7 @@
#include <QtCore/QTextStream>
#include <QtCore/QFile>
+#include <QRegExp>
#include <kdebug.h>
#include <kglobal.h>
@@ -216,23 +217,41 @@
{
s=t.readLine();
s=s.simplified();
- if ( (!s.isEmpty() ) && (s.indexOf(Delimiter)!=0) )
- {
+
+ if ( (!s.isEmpty() ) && (s.indexOf(Delimiter)!=0) )
+ {
// not empty or commented out by '#'
- // kDebug() << "GOT: [" << s << "]" ;
+ kDebug() << "GOT: [" << s << "]" ;
disk = new DiskEntry();
disk->setMounted(false);
- disk->setDeviceName(expandEscapes(s.left(s.indexOf(Blank))));
- s=s.remove(0,s.indexOf(Blank)+1 );
- // kDebug() << " deviceName: [" << disk->deviceName() << "]" ;
+ // We need to remove UUID=
+ bool isUuid = s.contains("UUID=");
+ if (isUuid)
+ {
+ QRegExp uuid("UUID=(\\S+)(\\s+)");
+ QString extracted ;
+ if (uuid.indexIn(s) != -1) {
+ extracted = uuid.cap(1);
+ }
+ QString device = QString("/dev/disk/by-uuid/") + extracted;
+ QFile file(device);
+ QString filesym = file.symLinkTarget();
+ disk->setDeviceName(device);
+ s=s.remove(0,s.indexOf(Blank)+1 );
+ }
+ else
+ {
+ disk->setDeviceName(expandEscapes(s.left(s.indexOf(Blank))));
+ s=s.remove(0,s.indexOf(Blank)+1 );
+ }
+ //kDebug() << " deviceName: [" << disk->deviceName() << "]" ;
#ifdef _OS_SOLARIS_
//device to fsck
s=s.remove(0,s.indexOf(Blank)+1 );
#endif
-
- disk->setMountPoint(expandEscapes(s.left(s.indexOf(Blank))));
- s=s.remove(0,s.indexOf(Blank)+1 );
- //kDebug() << " MountPoint: [" << disk->mountPoint() << "]" ;
+ disk->setMountPoint(expandEscapes(s.left(s.indexOf(Blank))));
+ s=s.remove(0,s.indexOf(Blank)+1 );
+ //kDebug() << " MountPoint: [" << disk->mountPoint() << "]" ;
//kDebug() << " Icon: [" << disk->iconName() << "]" ;
disk->setFsType(s.left(s.indexOf(Blank)) );
s=s.remove(0,s.indexOf(Blank)+1 );
@@ -263,7 +282,7 @@
loadSettings(); //to get the mountCommands
- // kDebug() << "DiskList::readFSTAB DONE" ;
+ //kDebug() << "DiskList::readFSTAB DONE" ;
return 1;
}
By Jove, I think he's fixed it! KwikDisk | KDiskFree v0.9 using KDE4.3.2 no longer shows duplicate rows, and all disk info is correct on each line. I think this one can be marked as fixed. > KDiskFree v0.9 using KDE4.3.2 no longer shows duplicate rows
It still does here. I guess this will be available in a later version?
this is fixed for andrew on kde 4.3.2 because he uses mandriva rpms where i put my fix. i wait for a review of my patch ( the review is in progress ) then i commit on KDE SVN commit 1034605 by nlecureuil: Allow to handle fstab when it contains UUID CCBUG:118123 M +60 -13 disklist.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1034605 SVN commit 1034733 by nlecureuil: forward port of revision 1034605 CCBUG:118123 M +60 -13 disklist.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1034733 I have this bug on kdf-4.3.85 (openSUSE) with filesystems mounted by label. Entries are shown twice, on the row with the device it's ok, on the row using the label there's no data. I don't have this in KDE 4.4.3/Debian unstable, looks much clearer now. :) |