Bug 118120

Summary:	PicAsm highlighting is missing IORWF, RLF, RRF
Product:	[Applications] kate	Reporter:	David Saxton <kdebugs>
Component:	general	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Adds iorf, rlf, rrf to highlighted instructions

Description David Saxton 2005-12-11 16:26:07 UTC

Version:            (using KDE KDE 3.5.0)
Installed from:    Ubuntu Packages

The syntax highlighting for the Microchip PIC assembly (picsrc.xml) is missing a few instructions (IORWF, RLF, RRF). I will attach a patch to this bug report to fix this.

Comment 1 David Saxton 2005-12-11 16:27:02 UTC

Created attachment 13862 [details]
Adds iorf, rlf, rrf to highlighted instructions

Comment 2 David Saxton 2006-01-13 14:19:17 UTC

"Apply me! Apply me!", said the lonely patch.

This pretty trivial patch shouldn't take more than a few seconds for someone to apply, but it's been here for over a month. Is there something wrong with the patch? (I cannot tell as no-one has commented yet). I have thoroughly tested it to make sure that it works properly.

Comment 3 Anders Lund 2006-01-13 19:21:14 UTC

On Friday 13 January 2006 14:19, David Saxton wrote:
[bugs.kde.org quoted mail]

Alain, are you maintaining this file? Me applying the patch would be me 
blindly believing that it is correct.

-anders

Comment 4 David Saxton 2006-01-13 20:14:22 UTC

In case Alain doesn't reply...you can verify that the patch is correct by going to the documentation for the PIC 14 bit instruction set:

http://ww1.microchip.com/downloads/en/devicedoc/31029a.pdf (page 3)

and noting that "iorf", "rlf" and "rrf" are all listed in that table, but are not current in kate's xml schema for PIC asm.

Comment 5 Dominik Haumann 2006-01-13 22:12:59 UTC

SVN commit 497790 by dhaumann:

Apply patch, BR #118120. Forward port follows.
Thanks to David Saxton, sorry for the delay.
BUG: 118120


 M  +7 -1      picsrc.xml  


--- branches/KDE/3.5/kdelibs/kate/data/picsrc.xml #497789:497790
@@ -8,7 +8,7 @@
   * Updated for 16-bit devices, etc.: Laurence Withers <lwithers@users.sf.net>
 -->
 
-<language name="PicAsm" version="1.06" kateversion="2.3" section="Assembler" extensions="*.src;*.SRC;*.asm;*.ASM;*.pic;*.PIC" mimetype="text/x-PicSrc;text/x-PicHdr" author="Alain GIBAUD (alain.gibaud@univ-valenciennes.fr)" license="LGPL">
+<language name="PicAsm" version="1.07" kateversion="2.3" section="Assembler" extensions="*.src;*.SRC;*.asm;*.ASM;*.pic;*.PIC" mimetype="text/x-PicSrc;text/x-PicHdr" author="Alain GIBAUD (alain.gibaud@univ-valenciennes.fr)" license="LGPL">
   
   <highlighting>
     <list name="directives">
@@ -163,6 +163,7 @@
       <item> incfsz </item>
       <item> infsnz </item>
       <item> iorlw </item>
+      <item> iorwf </item>
       <item> lfsr </item>
       <item> movf </item>
       <item> movff </item>
@@ -182,8 +183,10 @@
       <item> retlw </item>
       <item> return </item>
       <item> rlcf </item>
+      <item> rlf </item>
       <item> rlncf </item>
       <item> rrcf </item>
+      <item> rrf </item>
       <item> rrncf </item>
       <item> setf </item>
       <item> sleep </item>
@@ -233,6 +236,7 @@
       <item> INCFSZ </item>
       <item> INFSNZ </item>
       <item> IORLW </item>
+      <item> IORWF </item>
       <item> LFSR </item>
       <item> MOVF </item>
       <item> MOVFF </item>
@@ -252,8 +256,10 @@
       <item> RETLW </item>
       <item> RETURN </item>
       <item> RLCF </item>
+      <item> RLF </item>
       <item> RLNCF </item>
       <item> RRCF </item>
+      <item> RRF </item>
       <item> RRNCF </item>
       <item> SETF </item>
       <item> SLEEP </item>