Bug 117970

Summary:	kget konq integration doesnt work when severall files are selected
Product:	[Applications] kget	Reporter:	Zé <mmodem00>
Component:	general	Assignee:	KGet bugs <kget-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Zé 2005-12-09 00:44:06 UTC

Version:           v0.8.5 (using KDE 3.5.0, Mandriva Linux Cooker i586 - Cooker)
Compiler:          Target: i586-mandriva-linux-gnu
OS:                Linux (i686) release 2.6.12-12mdk

If in konqueror i select severall files and then right click in "Download with kget" will not happen anything, anyway it works fine if only one file is selected.

Comment 1 Urs Wolfer 2005-12-22 21:06:59 UTC

fixed

SVN commit 490685 by ratz:

Accept multiple urls from commandline. When there are two arguments and the 2nd is a local file, interpret as destination. BUG: 117970

 M  +15 -4     main.cpp  


--- branches/KDE/3.5/kdenetwork/kget/main.cpp #490684:490685
@@ -165,10 +165,21 @@
                 kmain->addTransferEx( KURL::fromPathOrURL( txt ),
                                       KURL());
         }
-        else if(args->count()==2)
-            kmain->addTransferEx( KURL::fromPathOrURL( args->arg(0) ),
-                                  KURL::fromPathOrURL( args->arg(1) ));
-
+        else if(args->count()>=2)
+               {
+                       KURL::List urls;
+                       QString dest;
+                       for( int i=0; i < args->count(); ++i){
+                               urls.append(KURL::fromPathOrURL( args->arg(i)));
+                       }
+                       if ( args->count()==2 & urls.last().protocol() == "file" )
+                       {
+                               dest=urls.last().path();
+                               kmain->addTransferEx( urls.first(), dest );
+                       }
+                       else
+                               kmain->addTransfers( urls, dest );
+               }
         args->clear();
 
 #ifdef _DEBUG

Comment 2 Zé 2005-12-25 03:36:24 UTC

I would like to understand where u get the idea that this fixes kget...

With this suposed fix now kget konqueror integration when clicking in a file it open the window to choose a folder instead the window to select the filename to save to.

Comment 3 Rainer Wirtz 2005-12-27 04:54:01 UTC

This was caused by a problem in kdelibs, should be fixed now.
Thanks for catching.