Bug 117740

Summary: ignoring authorisation in icq does not work as expected
Product: [Unmaintained] kopete Reporter: Leo Savernik <l.savernik>
Component: ICQ and AIM PluginsAssignee: Kopete Developers <kopete-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: complete log

Description Leo Savernik 2005-12-05 20:14:33 UTC 
Version:            (using KDE KDE 3.5.0)
Installed from:    Compiled From Sources

The good news, bug 101587 has been fixed. Thank you, guys! The bad news, it doesn't work.

For KDE 3.5, I've set my ICQ preferences as follows:

[x] Require authorization before someone can add you to their contact list.
[ ] Respect other contacts' wish to require authorization

Note it's the second option this bug is about. I included the first only in case they are dependent.

Now when I go online, half of my ICQ contacts are marked as "waiting for authorization". Sorry, what did I uncheck the above option for then?

Here's a snippet of debug output. If you need a more elaborate Version, I'll post one.

kopete (oscar - raw protocol): [void Oscar::SSI::checkTLVs()] Need auth for contact xxxx222
kopete (oscar - raw protocol): [void Oscar::SSI::checkTLVs()] Got an alias 'xxx' for contact 'xxxx222'
kopete (oscar - raw protocol): [void SSIListTask::handleSSIListReply()] Got SSI Item: name: xxxx222 gid: xxxx258 bid: xxxx489 type: 0 tlv length: 15
kopete (oscar - raw protocol): [bool SSIManager::newContact(const Oscar::SSI &)] Setting next contact ID to xxxx489
kopete (oscar - raw protocol): [bool SSIManager::newContact(const Oscar::SSI &)] Adding contact 'xxxx222' to SSI list
kopete (oscar - raw protocol): [void Oscar::SSI::checkTLVs()] Need auth for contact xxxx257
kopete (oscar - raw protocol): [void Oscar::SSI::checkTLVs()] Got an alias 'xxx' for contact 'xxxx257'
kopete (oscar - raw protocol): [void SSIListTask::handleSSIListReply()] Got SSI Item: name: xxxx257 gid: xxxx258 bid: xxxx574 type: 0 tlv length: 13
kopete (oscar - raw protocol): [bool SSIManager::newContact(const Oscar::SSI &)] Setting next contact ID to xxxx574
kopete (oscar - raw protocol): [bool SSIManager::newContact(const Oscar::SSI &)] Adding contact 'xxxx257' to SSI list
kopete (oscar - raw protocol): [void Oscar::SSI::checkTLVs()] Need auth for contact xxxx889
kopete (oscar - raw protocol): [void Oscar::SSI::checkTLVs()] Got an alias 'xxx' for contact 'xxxx889'
kopete (oscar - raw protocol): [void SSIListTask::handleSSIListReply()] Got SSI Item: name: xxxx889 gid: xxxx258 bid: xxxx852 type: 0 tlv length: 11
kopete (oscar - raw protocol): [bool SSIManager::newContact(const Oscar::SSI &)] Setting next contact ID to xxxx852
kopete (oscar - raw protocol): [bool SSIManager::newContact(const Oscar::SSI &)] Adding contact 'xxxx889' to SSI list
Comment 1 Jan Ritzerfeld 2005-12-05 21:42:41 UTC 
> Now when I go online, half of my ICQ contacts are marked as "waiting for authorization".

Are you sure that these contacts are actually online?

> Sorry, what did I uncheck the above option for then?

[...] the icq servers will send online status messages for all contacts even if they are in the "waiting for authorization" state.
I.e. you will see them online if they are online (or away, n/a...). If they are offline they will be shown as "waiting for authorization" to remind you that they never authorized you.
Please keep in mind that AOL is free to change the protocol anytime in the way that my "hack" will stop working. So it will not be save/correct to pretend that the "waiting for authorization" status can be evaded.
Comment 2 Leo Savernik 2005-12-05 23:33:59 UTC 
Am Montag, 5. Dezember 2005 21:42 schrieb Jan Ritzerfeld:
> If they are offline they will be shown as "waiting for authorization" to
> remind you that they never authorized you.


Ok. That makes sense. Since I can't tell whether any of those people was 
online, I'd like to leave this bug open unless I've gathered some proof.

> Please keep in mind that AOL is free to change the protocol anytime in the
> way that my "hack" will stop working. So it will not be save/correct to
> pretend that the "waiting for authorization" status can be evaded


Well, then AOL breaks it for *all* older clients. They haven't done so far, so 
I'm don't think they'd do it in the future (until Microsoft buys AOL ;-) )
Comment 3 Matt Rogers 2005-12-06 00:13:16 UTC 
can you provide the whole debug log from connection start up until login is finished as an attachment. The ignoring of the authorization is a seperate packet that isn't seen in the above output.
Comment 4 Leo Savernik 2005-12-06 22:41:21 UTC 
Created attachment 13793 [details]
complete log

As requested, the whole log of a short session comprised of starting, going
online, offline, and quitting.
Comment 5 Jan Ritzerfeld 2005-12-06 23:25:05 UTC 
There are 18 contacts on your server side list:
> kopete (oscar): [void OscarAccount::processSSIList()] Adding 18 contacts to contact list
And they are all added to the fake local contact list:
#sed -n "s/\(.*Adding contact \)\([x0-9]*\) to CLI_BUDDYLIST_ADD packet/\2/p" attachment.cgi | tee add | wc -l
18

P.S.: 11 of them need authorization:
#sed -n "s/\(.*Need auth for contact \)\([x0-9]*\)$/\2/p" attachment.cgi | tee need | wc -l
11
...and every contact needing auth is added to fake local contact list:
#diff add need | grep ">"
#
Comment 6 Matt Rogers 2006-01-13 04:13:43 UTC 
This worked for me in the 0.12 branch when I just tried it. 0.12 will be released in about three months with a beta version in about a month.