Bug 117414

Summary:	[PATCH] Icons for toolbar buttons are missing
Product:	[Unmaintained] kmail	Reporter:	Andres Kärner <andres.karner>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED WAITINGFORINFO
Severity:	normal	CC:	bjoern, forums, kollix
Priority:	NOR
Version:	1.9
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	KMail filter icons auto-update patch

Description Andres Kärner 2005-12-01 09:00:18 UTC

Version:           1.9 (using KDE 3.5.0 Level "a" , SUSE 9.3 UNSUPPORTED)
Compiler:          gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)
OS:                Linux (i686) release 2.6.11.4-21.9-default

After upgrading to KDE 3.5 icons for toolbar buttons "Filter Classify as spam" and "Filter Classify as NOT spam" are missing.

Comment 1 Andreas Gungl 2005-12-01 09:16:01 UTC

Please check the settings for these filters (in the second tab page).

Comment 2 Andres Kärner 2005-12-01 10:18:10 UTC

So? Yes, I can select there icon (actually I didn't find those icons yet) but bugreport was about that those icons were lost during update KDE 3.4.? -> 3.5 Why? When I was activating those filters then I didn't select icons manually - they were already there. So they should stay like that after update also??

Comment 3 Andreas Gungl 2005-12-01 17:55:19 UTC

*** Bug 117439 has been marked as a duplicate of this bug. ***

Comment 4 Daniel Schepler 2005-12-06 14:01:18 UTC

This appears to be happening because the icons got renamed from mark_as_spam.png to mail_spam.png, and the same for _ham.  Probably you should create an upgrade script to rename the filter icons in user configurations automatically.

Comment 5 David Baron 2005-12-07 16:40:02 UTC

They are simply missing in the distribution, both in 3.5-rc1 and 3.5.

I copied them from a previous distribution, restarted kmail. Easy enough workaround.

Comment 6 Andreas Gungl 2005-12-09 10:23:07 UTC

*** Bug 117439 has been marked as a duplicate of this bug. ***

Comment 7 Alexei Dets 2005-12-12 22:53:19 UTC

Small but annoying and very notable bug :-(
Names of the icons changed and nothing took care of this :-/
I had to manually edit ~/.kde/share/config/kmailrc to replace "mark_as_spam" with "mail_spam" and "mark_as_ham" with "mail_ham" to get the icons back.

Comment 8 Daniel Schepler 2005-12-20 10:52:59 UTC

Created attachment 13990 [details]
KMail filter icons auto-update patch

Here's the patch I created for the Debian kdepim packages, implementing an
auto-update of user configuration files for the new icon names.

Comment 9 Carsten Lohrke 2006-04-22 12:15:01 UTC

Could Daniel's patch please be included into cvs!? It is not distro specific and breaking user configuration should be fixed.

Comment 10 Carsten Lohrke 2006-04-30 14:13:24 UTC

Sorry for being insistant, but could you please include this before the freeze? The patch is fine, but I don't like too keep custom patches, which should be fixed upstream, forever. It's not like KDE has a good track record with updating user configuration data...

Comment 11 Martin Koller 2009-09-03 00:47:44 UTC

KDE4 now uses the icon name specification from freedesktop.org, so this patch is no longer correct.

Comment 12 Björn Ruberg 2009-12-24 01:32:56 UTC

So this is out of date.