| Summary: | batch tool 'start' not disabled when target folder is not writeable orwith no image in list | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Achim Bohnet <ach> |
| Component: | BatchQueueManager-Plugins | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | 0.1.0 | |
| Sentry Crash Report: | |||
|
Description
Achim Bohnet
2005-12-01 00:02:37 UTC
SVN commit 530136 by anaselli:
A workaround stops the process if the target directory is not writable.
BUG: 117397
M +12 -0 batchprocessimagesdialog.cpp
--- trunk/extragear/libs/kipi-plugins/batchprocessimages/batchprocessimagesdialog.cpp #530135:530136
@@ -488,6 +488,16 @@
// PENDING(blackie) handle remote URL's
QString targetAlbum = m_upload->path().path();
+ //TODO check if it is valid also for remote URL's
+ // this is a workarond for bug 117397
+ QFileInfo dirInfo(targetAlbum + "/");
+ if (!dirInfo.isDir () || !dirInfo.isWritable())
+ {
+ KMessageBox::error(this, i18n("You must specify a writable path for your output file."));
+ endProcess();
+ return true;
+ }
+
BatchProcessImagesItem *item = static_cast<BatchProcessImagesItem*>( m_listFile2Process_iterator->current() );
m_listFiles->setCurrentItem(item);
@@ -519,6 +529,8 @@
if ( KIO::NetAccess::exists( desturl ) == true )
#endif
{
+
+
switch (overwriteMode())
{
case OVERWRITE_ASK:
about the second point (no images selected) the process does nothing by now, so if you want the behavior to change open a wish. Angelo |