Bug 116729

Summary:	KWord: i18n patch broke Kabc mailmerge
Product:	[Unmaintained] kword	Reporter:	Dreisam-RD <dreisam-rd>
Component:	general	Assignee:	Thomas Zander <zander>
Status:	RESOLVED FIXED
Severity:	normal	CC:	zander
Priority:	NOR
Version:	1.5 or before
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Dreisam-RD 2005-11-19 23:51:46 UTC

Version:           1.4 (using KDE Devel)
Installed from:    Compiled sources

This patch
<http://websvn.kde.org/trunk/koffice/kword/mailmerge/kabc/kwmailmerge_kabc.cc?rev=404570&r1=393465&r2=404570>
broke the kabc mailmerge plugin. Now the plugin is worthless with any language other than the english one. There is no easy way to have translated mailmerge variables in the kword document (I guess, when designing the mailmerge stuff, it wasn't thought of this problem).

So I suggest to unapply this patch and let untranslated variables occur. I think it's much better to have an untranslated mailmerge system than a completely useless one.

Kinde Regards

Dirk

Comment 1 Fredrik Edemar 2006-02-18 02:59:32 UTC

SVN commit 510781 by fedemar:

Translate the strings both in KWMailMergeKABC::KWMailMergeKABC and KWMailMergeKABC::getValue so that the plugin finds the mail merge variable.
BUG: 116729


 M  +98 -98    KWMailMergeKABC.cpp

Comment 2 Robert Knight 2006-02-18 15:02:14 UTC

Fredrik just reverted my commit so its now broken again unfortunately.

Comment 3 Dreisam-RD 2006-02-18 21:34:31 UTC

Thanks Robert for your patch.

Fredrik, you are right (so why haven't you already done it last year?) and wrong.
One can put i18n() around the strings in KWMailMergeKABC::getValue and mailmerge works. But this method has 2 drawbacks.
1. Users using different languages cannot exchange documents.
2. The kabc mailmerge stuff then heavily depends on the translators. Any change of a translated string would break all documents created with some earlier translation version.

There is no easy way with the current design, to have an exchangeable and stable translated kabc mailmerge system.

May other developers decide whether translations or usability is more important.

Comment 4 Fredrik Edemar 2006-02-20 00:07:31 UTC

SVN commit 511456 by fedemar:

Sorry for reverting your patch Robert, I thought I'd solved the problem by translating the strings in getValue. As my solution has some problems which Dirk pointed out, I now untranslate the strings back.  

CCBUG: 116729


 M  +98 -98    KWMailMergeKABC.cpp

Comment 5 Thomas Zander 2008-08-06 19:45:14 UTC

obsolete, closing