| Summary: | Reply and Forward buttons in Yahoo Mail don't work | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Dan <DanMoinescu> |
| Component: | khtml | Assignee: | Maksim Orlovich <maksim> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | lbc, maksim, mtodorov3_69, pdenapo, rdieter, tgpfx |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | patch | ||
|
Description
Dan
2005-11-15 12:21:35 UTC
Created attachment 13470 [details]
patch
Apparently they rely on getAttribute on non-existing attributes returning null
and not empty, never mind what the DOM spec says (IE and Mozilla do that,
anyway)
Of course, as expected, this lights up like crazy in DOM tests, including one of the standard ones I can confirm this using kde3.5 rc1. This will be fixed i hope? Also ... I think the javascript showing suggested email addresses does not work either. Too late for 3.5, I am afraid, but should be in 3.5.1... where is the suggested e-mail addresses thing? when you type an email address in the to field, if it matches something youve used earlier or its in your book, it will show a dropdown and offer to fill it in. This doesn't happen in konq. I also can confirm it (using kde_3.5.0_rc1) I'll find it useful if you could fix this bug! I can confirm that the patch by Maksim Orlovich (comment #1) works for kde_3.5.0_rc1 That suggestion thing seems to go along with the rich-text composer, while we get the plain one; we can't handle the complex ATM, and it is hardly a trivial thing to support (falls under a major project of one of the contributors..) Maskim, thanks for fixing the button-not-working issue. What would be needed to support the richtext composer? SVN commit 486217 by orlovich:
Match mozilla + Safari, and return null on getAttribute
when it's not there. Fixes yahoomail and an unknown number of other sites.
BUG:116413
M +4 -1 kjs_dom.cpp
--- branches/KDE/3.5/kdelibs/khtml/ecma/kjs_dom.cpp #486216:486217
@@ -1088,7 +1088,10 @@
switch(id) {
case DOMElement::GetAttribute:
- return String(element.getAttribute(args[0].toString(exec).string()));
+ /** In theory, we should not return null here, as per DOM. In practice, that
+ breaks websites
+ */
+ return getString(element.getAttribute(args[0].toString(exec).string()));
case DOMElement::SetAttribute:
element.setAttribute(args[0].toString(exec).string(),args[1].toString(exec).string());
return Undefined();
As for the richtext composer: not sure, likely a huge amount of work *** Bug 119277 has been marked as a duplicate of this bug. *** *** Bug 120305 has been marked as a duplicate of this bug. *** *** Bug 120638 has been marked as a duplicate of this bug. *** Hi, I am using KDE 3.5 and am still hitting this bug. Since I use binary packages, how do I apply the patch, if any? Thanks. I don't think that there is a patch out for it yet, so I have switched to Firefox for dealing with Yahoo emails. --- Kanwar Plaha <Kanwar.Plaha@gmail.com> wrote: [bugs.kde.org quoted mail] ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com There is way of applying a source patch to binary packages -- you have to compile a new version. The easiest may be to wait a couple more days for 3.5.1 to be out. There is -NO- way, that is. For a long-term solution scrap yahoo mail altogether for gmail. I've had yahoo for five years now and I am slowly shifting to gmail. gmail's got it all - POP3, web access, smtp, huge mailbox, on top of that everything is secure, over SSL. I am tired of getting invalid certificate popup any time I call https://mail.yahoo.com. I can't believe yahoo can't pay $100/year to buy one, it's just ridiculous. |