Bug 116054

3.5 is string frozen, so we can't change it there. However it's fixed in the development branch. Thus I close this report.

BTW as of your suggestions, there is only a two-letters-difference between "Go online" and "Go offline". :-)

On Thursday 10 November 2005 14:17, Andreas Gungl wrote:
> BTW as of your suggestions, there is only a two-letters-difference between
> "Go online" and "Go offline". :-)


Yes, I know - hence the point I made at the end of that paragraph.

Might I inquire what is the current text for that feature ?

rev. 465368   Replace Network state with "Go On/Offline"

Why close this bug?
We can always change it after KDE 3.5.0 release, so the string can be changed 
for KDE 3.5.1. You can't close this bug so.

No, the string cannot be fixed for KDE 3.5.1.

But since it has already been fixed where it can be fixed, the bug is solved.

Why the string cannot be fixed for KDE 3.5.1?
KDE 3.5.1 will be a KDE 3.5.0 fix release, why not fix string too?
I really don't understand.

Because if you "fix" the string, all the translations get broken.

So we apply the "message freeze": no user-visible strings can be changed. Once a module goes into it, it never leaves. So, KDE 3.5's strings are frozen forever (except for really exceptional changes that got approval from translators).

It's the same with "feature freeze": no new features can be added to KDE 3.5 anymore.

A KDE Italian translator and KSniffer core developer
Slackware GNU/Linux current version - kernel 2.6.14
I know this, but it's not a valid reason to close this bug. A lot of string 
fix was done after KDE 3.3.0 release or after 3.4.0 . It is not possible fix 
bugs and not to fix the strings. If you let me do I'll write to translators 
mailing list after KDE 3.5.0 will be released and ask if I can make this fix, 
so this bug could be closed in the correct way. The bug or in source code or 
int string has to be correct. And this is a usability bug. Me too was 
confused from this KMail string.

Right, if the translators agree, then it can be done.

SVN commit 484247 by gianni:

so the bug #116054 it's been backported to 3.5 branch too
CCBUG:116054


 M  +4 -4      kmmainwidget.cpp  


--- branches/KDE/3.5/kdepim/kmail/kmmainwidget.cpp #484246:484247
@@ -1644,11 +1644,11 @@
 {
   if ( GlobalSettings::self()->networkState() == GlobalSettings::EnumNetworkState::Online ) {
     // if online; then toggle and set it offline.
-    actionCollection()->action( "online_status" )->setText( i18n("Network State (online)") );
+    actionCollection()->action( "online_status" )->setText( i18n("Go Online") );
     kmkernel->stopNetworkJobs();
     BroadcastStatus::instance()->setStatusMsg( i18n("KMail is set to be offline; all network jobs are suspended"));
   } else {
-    actionCollection()->action( "online_status" )->setText( i18n("Network State (offline)") );
+    actionCollection()->action( "online_status" )->setText( i18n("Go Offline") );
     kmkernel->resumeNetworkJobs();
     BroadcastStatus::instance()->setStatusMsg( i18n("KMail is set to be online; all network jobs resumed"));
   }
@@ -3000,9 +3000,9 @@
     actionCollection()->action( "send_queued" )->setEnabled( kmkernel->outboxFolder()->count() > 0 );
     actionCollection()->action( "send_queued_via" )->setEnabled( kmkernel->outboxFolder()->count() > 0 );
     if ( GlobalSettings::self()->networkState() == GlobalSettings::EnumNetworkState::Online )
-      actionCollection()->action( "online_status" )->setText( i18n("Network State (offline)") );
+      actionCollection()->action( "online_status" )->setText( i18n("Go Offline") );
     else
-      actionCollection()->action( "online_status" )->setText( i18n("Network State (online)") );
+      actionCollection()->action( "online_status" )->setText( i18n("Go Online") );
     if (action( "edit_undo" ))
       action( "edit_undo" )->setEnabled( mHeaders->canUndo() );