Bug 115535

Summary:	aspect ratio crop operation needs i18n for the string "Golden Ratio" in the aspect ratio combobox.
Product:	[Applications] digikam	Reporter:	Tung NGUYEN <ntung>
Component:	Usability-i18n	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	0.8.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	7.5.0
Sentry Crash Report:

Description Tung NGUYEN 2005-11-02 14:30:12 UTC

Version:           0.8.0-beta2 (using KDE KDE 3.4.2)
Installed from:    Compiled From Sources
OS:                Linux

the aspect ratio combobox has a tip : "<p>Select here your constrained aspect ratio for cropping. The Golden Ratio 1:1.618. A composition following this rule is considered visually harmonious". The string "Golden Ratio" in the tip is mostly translated by the different languages but the same string remain in english in the
combobox.

Comment 1 caulier.gilles 2005-11-02 14:34:28 UTC

SVN commit 476944 by cgilles:

Fix i18n
CCBUG: 115535


 M  +1 -1      imageeffect_ratiocrop.cpp  


--- trunk/extragear/graphics/digikam/imageplugins/imageeffect_ratiocrop.cpp #476943:476944
@@ -95,7 +95,7 @@
     m_ratioCB->insertItem( "4:5" );
     m_ratioCB->insertItem( "5:7" );
     m_ratioCB->insertItem( "7:10" );
-    m_ratioCB->insertItem( "Golden Ratio" );
+    m_ratioCB->insertItem( i18n("Golden Ratio") );
     m_ratioCB->insertItem( i18n("None") );
     m_ratioCB->setCurrentText( "1:1" );
     QWhatsThis::add( m_ratioCB, i18n("<p>Select here your constrained aspect ratio for cropping. "

Comment 2 caulier.gilles 2005-11-02 14:34:47 UTC

*** Bug has been marked as fixed ***.

Comment 3 caulier.gilles 2021-12-30 15:50:25 UTC

Fixed with works from bug #438701 for next 7.5.0 release

Gilles Caulier