| Summary: | hexprinter.cc 'size.height' is used uninitialized in this function | ||
|---|---|---|---|
| Product: | [Unmaintained] khexedit | Reporter: | Marcin Garski <mgarski> |
| Component: | general | Assignee: | Espen Sand <espensa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
SVN commit 475024 by goutte: Initialize correctly the variables (Not tested) CCBUG:115227 M +1 -1 hexprinter.cc --- branches/KDE/3.5/kdeutils/khexedit/hexprinter.cc #475023:475024 @@ -131,7 +131,7 @@ QPaintDeviceMetrics metric( this ); SPageSize size; size.width = metric.width(); - size.width = metric.height(); + size.height = metric.height(); return( size ); } SVN commit 475026 by goutte: Initialize correctly the variables (Foreward port of revision 475024; not tested) BUG:115227 M +1 -1 hexprinter.cc --- trunk/KDE/kdeutils/khexedit/hexprinter.cc #475025:475026 @@ -131,7 +131,7 @@ QPaintDeviceMetrics metric( this ); SPageSize size; size.width = metric.width(); - size.width = metric.height(); + height.width = metric.height(); return( size ); } SVN commit 475028 by goutte: Grr, writing rubbish does not count... CCBUG:115227 M +1 -1 hexprinter.cc --- trunk/KDE/kdeutils/khexedit/hexprinter.cc #475027:475028 @@ -131,7 +131,7 @@ QPaintDeviceMetrics metric( this ); SPageSize size; size.width = metric.width(); - height.width = metric.height(); + size.height = metric.height(); return( size ); } |
Version: (using KDE Devel) Installed from: Compiled sources Compiler: gcc version 4.0.1 20050727 (Red Hat 4.0.1-5) OS: Linux In khexedit/hexprinter.cc file there is a function: SPageSize CHexPrinter::pageFullSize( void ) { QPaintDeviceMetrics metric( this ); SPageSize size; size.width = metric.width(); size.width = metric.height(); return( size ); } Second 'size.width' probably should be 'size.height', otherwise 'size.height' is uninitialized.