Bug 114384

Summary:	[PATCH] Add multiple files and directories
Product:	[Unmaintained] kdeprint	Reporter:	kdebugs
Component:	general	Assignee:	KDEPrint Devel Mailinglist <kde-print-devel>
Status:	CLOSED FIXED
Severity:	wishlist	CC:	jlayt
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch to implement

Description kdebugs 2005-10-14 10:39:29 UTC

Version:            (using KDE KDE 3.4.2)
Installed from:    SuSE RPMs

The kprinter file dialog only allows to add one file at once. You can add multiple files only by drag&drop from another konqueror-window, but it takes time to find out. 

I wish to open multiple files within the kprinter dialog - and perhaps the possibility to add a complete directory.

Comment 1 Philip Rodrigues 2005-10-15 17:03:12 UTC

This feature appears to be available in 3.5 - there's an "add file" button, which you can use as many times as you like.

Comment 2 kdebugs 2005-10-15 17:20:22 UTC

The "add file" button is in KDE 3.4.3 too. The problem is: when you have a directory with 60 files to print you have to use this button 60 times and select in 60 dialogs one file each.

Comment 3 Philip Rodrigues 2006-02-11 19:40:39 UTC

Ah, I see. So the simple solution would be to allow multiple files to be selected in the Open Dialog there, which seems to be the correct thing to do anyway.

Comment 4 kdebugs 2006-02-11 19:56:41 UTC

Exactly

Comment 5 Philip Rodrigues 2006-04-05 22:42:24 UTC

Created attachment 15485 [details]
patch to implement

Here's a (slightly tested) patch to implement this. Apply to kdelibs/kdeprint/.
Hope it's useful!

Comment 6 Cristian Tibirna 2006-04-06 06:21:50 UTC

SVN commit 526968 by tibirna:

Allow adding multiple files to the to-be-printed list
Thanks to Philip Rodrigues for the patch. I tested it.
BUG:114384


 M  +3 -3      kfilelist.cpp  


--- branches/KDE/3.5/kdelibs/kdeprint/kfilelist.cpp #526967:526968
@@ -243,9 +243,9 @@
 
 void KFileList::slotAddFile()
 {
-	KURL	fname = KFileDialog::getOpenURL(QString::null, QString::null, this);
-	if (!fname.isEmpty())
-		addFiles(KURL::List(fname));
+	KURL::List fnames = KFileDialog::getOpenURLs(QString::null, QString::null, this);
+	if (!fnames.empty())
+		addFiles(fnames);
 }
 
 void KFileList::slotRemoveFile()

Comment 7 John Layt 2008-12-31 19:06:24 UTC

Closing old Resolved status bug.