Bug 111564

Summary:	deleting or moving a bookmark can take FOUR SECONDS OF CPU TIME on an Athlon XP 2000+ system.
Product:	[Applications] keditbookmarks	Reporter:	Peter Grandi <pg_kde>
Component:	general	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	contact
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Peter Grandi 2005-08-26 16:41:45 UTC

Version:            (using KDE KDE 3.4.2)
Installed from:    Unlisted Binary Package
OS:                Linux

Perhaps it is a wish list, but the effect is so large that I think it is properly a performance bug...

My bookmark list has about six thousand bookmarks in several dozen folders and subfolders; the 'bookmarks.xml' is 1.5MB large.

When I delete a bookmark or move it even within the same folder 'keditbookmarks' chews up several seconds of (user) CPU time (it is actual CPU time, not mere wait time, I checked) on a fairly fast system.

It feels like that the time taken to delete or move a bookmark is proportional to the total number of bookmarks.

Looking at the screen it seems like the entire bookmark tree is being redisplayed, as the display looks ''partially redrawn'' for most of those several seconds.

Comment 1 Peter Grandi 2006-02-12 18:06:39 UTC

Speaking with some people on '#KDE-devel', their impression is that most of the time is taken by writing out the whole bookmarks file in XML more than by redisplay, which is also an issue.

Comment 2 Daniel Teske 2006-02-12 18:19:03 UTC

Well 6000 bookmarks is probably a little insane. Profiling seemed to indicate that elimanating a few calls to KBookmark::address() could make a difference, as a lot of time was spend in it.

I even have a few ideas how to improve it, but I currently don't have the time to work on it.

Comment 3 Peter Grandi 2006-06-01 07:06:07 UTC

It might be enough to allow choosing explicit saves, where saving the bookmark list does not take place after every single operation.

I don't mind waiting a bit every now and then when I save the list. But several seconds of pause on every change is pretty appalling.

Comment 4 Jean-Philippe Fleury 2009-02-03 02:19:09 UTC

Isn't a duplicate of bug 59401?

Comment 5 Peter Grandi 2009-02-07 20:12:56 UTC

«Isn't a duplicate of bug 59401?»

Yes, it looks like it is a duplicate, so linked them, even if bug 59401 was initially misdiagnosed as a broadcast-update issue. It is instead very clearly a save-data slowness issue.

I am marking this as a duplicate and then I'll add some new information to it.

*** This bug has been marked as a duplicate of bug 59401 ***