Bug 111071

SVN commit 452871 by dannya:

BUG:111071 Fix bug - the first part only slightly modified, as I think that file size is not the only intended metric (perhaps tree depth, etc?)

 M  +12 -13    index.docbook  


--- branches/KDE/3.5/kdeaddons/doc/konq-plugins/fsview/index.docbook #452870:452871
@@ -52,12 +52,11 @@
 listviews for browsing the content of your local file system.</para>
 
 <para>The unique property of &fsview; is its ability to show whole
-nested folder hierarchies by using a so called tree map for graphical
-visualization. Tree maps allow for showing metrics of objects in
+nested folder hierarchies using a so-called tree map for graphical
+visualization. Tree maps allow for displaying metrics of objects in
 nested structures: each object is represented by a rectangle whose
-area is proportional to its metric. The metric must have the property
-that the sum of the children's metrics of some object is equal or
-smaller than the objects metric.</para>
+area is proportional to its metric. The sum of the children's metrics must be
+equal to or smaller than the parent object's metric.</para>
 
 <para>For &fsview;, sizes of files and folders are choosen as
 metric, where the the size of a folder is defined to be the sum of the
@@ -71,7 +70,7 @@
 sensitive actions. But it was choosen not to implement automatical
 update of file system changes by watching: if you delete a file shown
 in &fsview; outside of &konqueror;, you have to update manually by
-&eg; pressing <keycap>F5</keycap>.  The reason for this decision is
+&eg; pressing <keycap>F5</keycap>. The reason for this decision is
 the potentially huge amount of files which would have to be watched
 for changes, and thus, could put an unreasonable pressure on system
 resources for a small feature.</para>
@@ -128,7 +127,7 @@
 <para>How the space of an item is split into subareas for children is
 left to the implementation. It is always better to try to split areas
 in such a way that rectangles are as quadratic as possible, both for
-labeling and less space lost by borders.  The best methods in this
+labeling and less space lost by borders. The best methods in this
 regard are <guilabel>Rows</guilabel>, <guilabel>Columns</guilabel>, or
 <guilabel>Recursive Bisection</guilabel>.</para>
 
@@ -136,7 +135,7 @@
 menu item <menuchoice><guimenu>View</guimenu><guimenuitem>Stop at
 Area</guimenuitem></menuchoice>. Instead, a hash pattern will be drawn
 over the parents area to signal that this space is in fact occupied by
-a child.  </para>
+a child.</para>
 
 </sect3>
 
@@ -147,18 +146,18 @@
 
 <para>&fsview; supports multiple selection of items, similar to the
 iconview and listview. This allows for actions to be done
-simultaniously to a set of files.  A simple mouse click always selects
+simultaniously to a set of files. A simple mouse click always selects
 a single item below the mouse pointer. Use a mouse click in
 combination with pressing the &Shift; key for range selection or the
-&Ctrl; Key for selection toggle. Note that by selecting an item,
-subitems can't be selected any longer. Thus, selecting an item will
-clear the selection of all its parent items before.  </para>
+&Ctrl; Key for selection toggle. Note that by selecting an item, subitems can no
+longer be selected. Selecting an item will also clear the selection of all its
+parent items before.</para>
 
 <para>There is keyboard navigation available in tree maps: use
 <keycap>Left Arrow</keycap> and <keycap>Right Arrow</keycap> keys to
 move the current item between siblings, and the <keycap>Up
 Arrow</keycap> and <keycap>Down Arrow</keycap> keys to go up and down
-the nesting hierarchy.  <keycap>Space</keycap> selects the item, in
+the nesting hierarchy. <keycap>Space</keycap> selects the item, in
 conjunction with &Shift; does range selection, and with the &Ctrl; key
 hold down simultaniously, toggles selection of the current item. Press
 <keycap>Return</keycap> to run the open action onto the current item.</para>

Danny wrote:
  BUG:111071 Fix bug - the first part only slightly modified, as I think that file size is not the only intended metric (perhaps tree depth, etc?)


Maybe the original author could give an explanation?

Natalie, do you think you would be able to find and ask the original author to ask?

Danny

Hi Danny,

Found the address, asked the question, now we just wait ;)

Natalie

Hi Danny,

The 24th of august I mailed Josef Weidendorfer about the metrics, still no reply ... :(

=== START QUOTE
Date: 2005-08-24 18:31
 From: Natalie <nat@switch.demon.nl>  (None whatsoever ...)
 To: Josef.Weidendorfer@gmx.de
 
Hi Josef,

While reviewing the Dutch translation of konq_plugins_fsview.po I 
encountered this sentence:

index.docbook:54

  The metric must have the property that the sum of the
  children's metrics of some object is equal or smaller
  than the object's metric.


I submitted a bug report 
(http://bugs.kde.org/show_bug.cgi?id=111071)
with this comment:

- I must be missing something ...
  It seems rather obvious that the metric (the size)
  has the property that the sum of the children's metrics
  (the sum of subdir sizes and file sizes) is equal or
  smaller than the object's metric (the directory's size).


Danny Allen wrote an additional comment:
  BUG:111071 Fix bug - the first part only slightly modified,
  as I think that file size is not the only intended metric
  (perhaps tree depth, etc?)


Can you please explain what you meant by these "metrics"?

Thanks :)

=== END QUOTE


Maybe you could try again ... 

Cheers,

Natalie