Bug 110729

Summary:	Tab order in many dialogs is counter-intuitive
Product:	[Applications] kst	Reporter:	Matthew Truch <matt>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.x
Target Milestone:	---
Platform:	RedHat Enterprise Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Matthew Truch 2005-08-13 23:47:07 UTC

Version:           1.2.0_devel (using KDE KDE 3.4.0)
Installed from:    RedHat RPMs
OS:                Linux

In many of kst's dialogs, hitting tab (or shift-tab) brings you to another entry in the dialog that is *not* the logical next (or previous) entry.  Some dialogs are better than others.  One of the worst is the appearance tab of the edit plot dialog.  

How to Reproduce:
1. Run kst.
2. Open the edit plot dialog from the plots menu.
3. Click on the appearance tab.
4. Click on one of the text entry fields.
5. Click tab (many times) to cycle nearly randomly through the entries.

Expected behavior: Tab cycles you through in some kind of logical order (from top to bottom; left to right; etc)

Comment 1 Andrew Walker 2005-08-15 22:38:57 UTC

SVN commit 449520 by arwalker:

CCBUG:110729 There are a lot of these. The approach is to fix the tab order, as best as possible. Also set buddies where applicable.

 M  +16 -6     changefiledialog.ui  
 M  +6 -0      choosecolordialog.ui  
 M  +12 -1     fftoptionswidget.ui  


--- trunk/extragear/graphics/kst/kst/changefiledialog.ui #449519:449520
@@ -8,7 +8,7 @@
         <rect>
             <x>0</x>
             <y>0</y>
-            <width>473</width>
+            <width>481</width>
             <height>600</height>
         </rect>
     </property>
@@ -192,8 +192,11 @@
                                 <cstring>textLabel1</cstring>
                             </property>
                             <property name="text">
-                                <string>File:</string>
+                                <string>&amp;File:</string>
                             </property>
+                            <property name="buddy" stdset="0">
+                                <cstring>_dataFile</cstring>
+                            </property>
                         </widget>
                         <widget class="QLayoutWidget" row="0" column="1">
                             <property name="name">
@@ -225,7 +228,7 @@
                                 <cstring>_changeSelected</cstring>
                             </property>
                             <property name="text">
-                                <string>Change selected vectors and matrices</string>
+                                <string>C&amp;hange selected vectors and matrices</string>
                             </property>
                             <property name="checked">
                                 <bool>true</bool>
@@ -280,7 +283,7 @@
                                 <cstring>_duplicateDependents</cstring>
                             </property>
                             <property name="text">
-                                <string>Duplicate dependents</string>
+                                <string>D&amp;uplicate dependents</string>
                             </property>
                         </widget>
                         <widget class="QRadioButton" row="0" column="0">
@@ -288,7 +291,7 @@
                                 <cstring>_duplicateSelected</cstring>
                             </property>
                             <property name="text">
-                                <string>Duplicate selected vectors and matrices</string>
+                                <string>&amp;Duplicate selected vectors and matrices</string>
                             </property>
                         </widget>
                     </grid>
@@ -352,6 +355,8 @@
         </widget>
     </grid>
 </widget>
+<customwidgets>
+</customwidgets>
 <connections>
     <connection>
         <sender>ChangeFileCancel</sender>
@@ -361,12 +366,17 @@
     </connection>
 </connections>
 <tabstops>
+    <tabstop>_allFromFile</tabstop>
+    <tabstop>_files</tabstop>
     <tabstop>_clearFilter</tabstop>
     <tabstop>_filter</tabstop>
+    <tabstop>ChangeFileCurveList</tabstop>
     <tabstop>ChangeFileClear</tabstop>
     <tabstop>ChangeFileSelectAll</tabstop>
-    <tabstop>ChangeFileCurveList</tabstop>
     <tabstop>_dataFile</tabstop>
+    <tabstop>_changeSelected</tabstop>
+    <tabstop>_duplicateSelected</tabstop>
+    <tabstop>_duplicateDependents</tabstop>
     <tabstop>ChangeFileApply</tabstop>
     <tabstop>ChangeFileCancel</tabstop>
 </tabstops>
--- trunk/extragear/graphics/kst/kst/choosecolordialog.ui #449519:449520
@@ -128,5 +128,11 @@
         <slot>reject()</slot>
     </connection>
 </connections>
+<tabstops>
+    <tabstop>xVector</tabstop>
+    <tabstop>yVector</tabstop>
+    <tabstop>OK</tabstop>
+    <tabstop>Cancel</tabstop>
+</tabstops>
 <layoutdefaults spacing="6" margin="11"/>
 </UI>
--- trunk/extragear/graphics/kst/kst/fftoptionswidget.ui #449519:449520
@@ -8,7 +8,7 @@
         <rect>
             <x>0</x>
             <y>0</y>
-            <width>479</width>
+            <width>488</width>
             <height>129</height>
         </rect>
     </property>
@@ -427,6 +427,17 @@
         <slot>changedApodizeFxn()</slot>
     </connection>
 </connections>
+<tabstops>
+    <tabstop>Apodize</tabstop>
+    <tabstop>ApodizeFxn</tabstop>
+    <tabstop>Sigma</tabstop>
+    <tabstop>RemoveMean</tabstop>
+    <tabstop>Interleaved</tabstop>
+    <tabstop>FFTLen</tabstop>
+    <tabstop>SampRate</tabstop>
+    <tabstop>VectorUnits</tabstop>
+    <tabstop>RateUnits</tabstop>
+</tabstops>
 <includes>
     <include location="global" impldecl="in implementation">kmessagebox.h</include>
     <include location="local" impldecl="in implementation">kst.h</include>

Comment 2 Andrew Walker 2005-08-15 22:55:09 UTC

SVN commit 449524 by arwalker:

CCBUG:110729 More

 M  +31 -18    csddialog.ui  
 M  +6 -3      curveappearancewidget.ui  
 M  +33 -26    curvedialog.ui

Comment 3 Andrew Walker 2005-08-15 23:06:00 UTC

SVN commit 449528 by arwalker:

CCBUG:110729 More

 M  +11 -3     curveplacementwidget.ui  
 M  +1 -0      datamanager.ui  
 M  +71 -207   datawizard.ui

Comment 4 Andrew Walker 2005-08-15 23:30:45 UTC

SVN commit 449543 by arwalker:

CCBUG:110729 More

 M  +5 -2      graphfiledialog.ui  
 M  +37 -26    hsdialog.ui  
 M  +19 -2     imagedialog.ui

Comment 5 Andrew Walker 2005-08-16 00:09:59 UTC

SVN commit 449549 by arwalker:

CCBUG:110729 More

 M  +5 -3      kstsettingsdlg.ui  
 M  +77 -11    matrixdialog.ui  
 M  +180 -4    plotdialog.ui

Comment 6 Andrew Walker 2005-08-16 00:38:34 UTC

SVN commit 449561 by arwalker:

CCBUG:110729 More

 M  +6 -1      plugindialog.ui  
 M  +3 -0      psddialog.ui  
 M  +7 -0      vectordialog.ui  
 M  +6 -0      vectorsavedialog.ui  


--- trunk/extragear/graphics/kst/kst/plugindialog.ui #449560:449561
@@ -50,6 +50,9 @@
                     <property name="text">
                         <string>Unique name:</string>
                     </property>
+                    <property name="buddy" stdset="0">
+                        <cstring>_tagName</cstring>
+                    </property>                
                 </widget>
                 <widget class="QLineEdit">
                     <property name="name">
@@ -246,8 +249,10 @@
     </connection>
 </connections>
 <tabstops>
+    <tabstop>_tagName</tabstop>
     <tabstop>PluginCombo</tabstop>
-    <tabstop>_pluginManager</tabstop>
+    <tabstop>_pluginManager</tabstop>'
+    <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
 </tabstops>
 <signals>
--- trunk/extragear/graphics/kst/kst/psddialog.ui #449560:449561
@@ -331,10 +331,13 @@
     </connection>
 </connections>
 <tabstops>
+    <tabstop>_tagName</tabstop>
+    <tabstop>_editMultiple</tabstop>
     <tabstop>_vector</tabstop>
     <tabstop>_kstFFTOptions</tabstop>
     <tabstop>_curveAppearance</tabstop>
     <tabstop>_curvePlacement</tabstop>
+    <tabstop>editMultipleWidget</tabstop>
     <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
 </tabstops>
--- trunk/extragear/graphics/kst/kst/vectordialog.ui #449560:449561
@@ -571,10 +571,17 @@
 </images>
 <tabstops>
     <tabstop>_tagName</tabstop>
+    <tabstop>_editMultiple</tabstop>
+    <tabstop>_readFromSource</tabstop>
+    <tabstop>_generateX</tabstop>
     <tabstop>FileName</tabstop>
     <tabstop>Field</tabstop>
     <tabstop>_configure</tabstop>
     <tabstop>_kstDataRange</tabstop>
+    <tabstop>_N</tabstop>
+    <tabstop>_xMin</tabstop>
+    <tabstop>_xMax</tabstop>
+    <tabstop>editMultipleWidget</tabstop>
     <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
 </tabstops>
--- trunk/extragear/graphics/kst/kst/vectorsavedialog.ui #449560:449561
@@ -155,6 +155,12 @@
     <slot>init()</slot>
     <slot access="private">selectionChanged()</slot>
 </slots>
+<tabstops>
+    <tabstop>_vectorList</tabstop>
+    <tabstop>_multiOptions</tabstop>
+    <tabstop>_saveButton</tabstop>
+    <tabstop>pushButton2</tabstop>
+</tabstops>
 <layoutdefaults spacing="6" margin="11"/>
 <includehints>
     <includehint>kcombobox.h</includehint>

Comment 7 Andrew Walker 2005-08-16 01:20:34 UTC

SVN commit 449568 by arwalker:

BUG:110729 Should be all

 M  +1 -0      changenptsdialog.ui  
 M  +1 -0      csddialog.ui  
 M  +11 -0     curvedialog.ui  
 M  +4 -4      eqdialog.ui  
 M  +2 -2      eventmonitor.ui  
 M  +4 -3      hsdialog.ui  
 M  +2 -1      imagedialog.ui  
 M  +1 -0      matrixdialog.ui  
 M  +2 -2      plotdialog.ui  


--- trunk/extragear/graphics/kst/kst/changenptsdialog.ui #449567:449568
@@ -194,6 +194,7 @@
     <tabstop>CurveList</tabstop>
     <tabstop>Clear</tabstop>
     <tabstop>SelectAll</tabstop>
+    <tabstop>_kstDataRange</tabstop>
     <tabstop>Apply</tabstop>
     <tabstop>Cancel</tabstop>
 </tabstops>
--- trunk/extragear/graphics/kst/kst/csddialog.ui #449567:449568
@@ -456,6 +456,7 @@
 <tabstops>
     <tabstop>_tagName</tabstop>
     <tabstop>_editMultiple</tabstop>
+    <tabstop>_vector</tabstop>
     <tabstop>_windowSize</tabstop>
     <tabstop>_palette</tabstop>
     <tabstop>_OK</tabstop>
--- trunk/extragear/graphics/kst/kst/curvedialog.ui #449567:449568
@@ -501,8 +501,16 @@
 <tabstops>
     <tabstop>_tagName</tabstop>
     <tabstop>_editMultiple</tabstop>
+    <tabstop>_xVector</tabstop>
+    <tabstop>_yVector</tabstop>
+    <tabstop>_xError</tabstop>
+    <tabstop>_xMinusError</tabstop>
     <tabstop>_checkBoxXMinusSameAsPlus</tabstop>
     <tabstop>_checkBoxYMinusSameAsPlus</tabstop>
+    <tabstop>_yError</tabstop>
+    <tabstop>_yMinusError</tabstop>
+    <tabstop>_curveAppearance</tabstop>
+    <tabstop>_curvePlacement</tabstop>
     <tabstop>_checkBoxIgnoreAutoscale</tabstop>
     <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
@@ -512,6 +520,9 @@
     <tabstop>_xError</tabstop>
     <tabstop>_yError</tabstop>
     <tabstop>_curvePlacement</tabstop>
+    <tabstop>editMultipleWidget</tabstop>
+    <tabstop>_OK</tabstop>
+    <tabstop>_cancel</tabstop>
 </tabstops>
 <signals>
     <signal>modified()</signal>
--- trunk/extragear/graphics/kst/kst/eqdialog.ui #449567:449568
@@ -451,15 +451,15 @@
     <tabstop>_tagName</tabstop>
     <tabstop>_editMultiple</tabstop>
     <tabstop>Operators</tabstop>
-    <tabstop>_equation</tabstop>
-    <tabstop>_doInterpolation</tabstop>
-    <tabstop>_OK</tabstop>
-    <tabstop>_cancel</tabstop>
     <tabstop>_vectors</tabstop>
     <tabstop>_scalars</tabstop>
+    <tabstop>_equation</tabstop>
     <tabstop>_xVectors</tabstop>
+    <tabstop>_doInterpolation</tabstop>
     <tabstop>_curveAppearance</tabstop>
     <tabstop>_curvePlacement</tabstop>
+    <tabstop>_OK</tabstop>
+    <tabstop>_cancel</tabstop>
 </tabstops>
 <signals>
     <signal>modified()</signal>
--- trunk/extragear/graphics/kst/kst/eventmonitor.ui #449567:449568
@@ -666,6 +666,8 @@
     <tabstop>_tagName</tabstop>
     <tabstop>_editMultiple</tabstop>
     <tabstop>comboBoxEqOperator</tabstop>
+    <tabstop>_vectorSelectorEq</tabstop>
+    <tabstop>_scalarSelectorEq</tabstop>
     <tabstop>lineEditEquation</tabstop>
     <tabstop>lineEditDescription</tabstop>
     <tabstop>checkBoxDebug</tabstop>
@@ -678,8 +680,6 @@
     <tabstop>_pushButtonELOGConfigure</tabstop>
     <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
-    <tabstop>_vectorSelectorEq</tabstop>
-    <tabstop>_scalarSelectorEq</tabstop>
 </tabstops>
 <layoutdefaults spacing="6" margin="11"/>
 <includehints>
--- trunk/extragear/graphics/kst/kst/hsdialog.ui #449567:449568
@@ -569,17 +569,18 @@
 <tabstops>
     <tabstop>_tagName</tabstop>
     <tabstop>_editMultiple</tabstop>
+    <tabstop>_vector</tabstop>
     <tabstop>Min</tabstop>
     <tabstop>Max</tabstop>
     <tabstop>N</tabstop>
     <tabstop>AutoBin</tabstop>
     <tabstop>_realTimeAutoBin</tabstop>
     <tabstop>NormIsNumber</tabstop>
+    <tabstop>_curveAppearance</tabstop>
+    <tabstop>_curvePlacement</tabstop>
+    <tabstop>editMultipleWidget</tabstop>
     <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
-    <tabstop>_vector</tabstop>
-    <tabstop>_curveAppearance</tabstop>
-    <tabstop>_curvePlacement</tabstop>
 </tabstops>
 <signals>
     <signal>modified()</signal>
--- trunk/extragear/graphics/kst/kst/imagedialog.ui #449567:449568
@@ -703,6 +703,7 @@
 <tabstops>
     <tabstop>_tagName</tabstop>
     <tabstop>_editMultiple</tabstop>
+    <tabstop>_matrix</tabstop>
     <tabstop>_colorOnly</tabstop>
     <tabstop>_palette</tabstop>
     <tabstop>_lowerZ</tabstop>
@@ -713,9 +714,9 @@
     <tabstop>_contourColor</tabstop>
     <tabstop>_contourWeight</tabstop>
     <tabstop>_useVariableWeight</tabstop>
+    <tabstop>editMultipleWidget</tabstop>
     <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
-    <tabstop>_matrix</tabstop>
     <tabstop>_curvePlacement</tabstop>
 </tabstops>
 <layoutdefaults spacing="6" margin="11"/>
--- trunk/extragear/graphics/kst/kst/matrixdialog.ui #449567:449568
@@ -1039,6 +1039,7 @@
     <tabstop>_minY</tabstop>
     <tabstop>_xStep</tabstop>
     <tabstop>_yStep</tabstop>
+    <tabstop>editMultipleWidget</tabstop>
     <tabstop>_OK</tabstop>
     <tabstop>_cancel</tabstop>
 </tabstops>
--- trunk/extragear/graphics/kst/kst/plotdialog.ui #449567:449568
@@ -3241,6 +3241,8 @@
     <tabstop>_plotColumns</tabstop>
     <tabstop>TabWidget</tabstop>
     <tabstop>Name</tabstop>
+    <tabstop>DisplayedCurveList</tabstop>
+    <tabstop>AvailableCurveList</tabstop>
     <tabstop>CurveUnplot</tabstop>
     <tabstop>CurvePlot</tabstop>
     <tabstop>_majorGridColor</tabstop>
@@ -3340,8 +3342,6 @@
     <tabstop>New</tabstop>
     <tabstop>Edit</tabstop>
     <tabstop>Close</tabstop>
-    <tabstop>DisplayedCurveList</tabstop>
-    <tabstop>AvailableCurveList</tabstop>
 </tabstops>
 <layoutdefaults spacing="6" margin="11"/>
 <includehints>