Bug 110698

This appears to be a plugin. Btw, using it leaves the image with at least 3 different dates - the file mdate, the digikam date and the EXIF date. I'd like to suggest that the plugin explains what it will do, that client applications uses it in that way, and that it allows to store adjust both the file date and the EXIF date(s) with a clear GUI.

>
> ------- Additional Comments From anders alweb dk  2005-08-13 13:30 -------
> This appears to be a plugin. Btw, using it leaves the image with at least 3
> different dates - the file mdate, the digikam date and the EXIF date. I'd
> like to suggest that the plugin explains what it will do, that client
> applications uses it in that way, and that it allows to store adjust both
> the file date and the EXIF date(s) with a clear GUI.


This is a kipi-plugin that has to be discussed with all other KDE graphical 
applications that use these plugins. I don't know the appropriate ML, though.

Gerhard

On Saturday 13 August 2005 13:35, Gerhard Kulzer wrote:
> This is a kipi-plugin that has to be discussed with all other KDE graphical
> applications that use these plugins. I don't know the appropriate ML,
> though.


I know little about the internals of kipi plugins, but is it possible that 
digikam uses it wrong? i would expect to be able to adjust more than once, 
but given the current way it reads/stores the data, that is not possible. And 
having all those different dates is really weird. I repeat, the file mdate, 
or the EXIF dates, or all should be targeted, depending on user choice. And 
reading and writing in the same place is the only thing that can justify the 
'adjust' in the name ;)

> On Saturday 13 August 2005 13:35, Gerhard Kulzer wrote:
> > This is a kipi-plugin that has to be discussed with all other KDE
> > graphical applications that use these plugins. I don't know the
> > appropriate ML, though.
>
> I know little about the internals of kipi plugins, but is it possible that
> digikam uses it wrong? i would expect to be able to adjust more than once,
> but given the current way it reads/stores the data, that is not possible.
> And having all those different dates is really weird. I repeat, the file
> mdate, or the EXIF dates, or all should be targeted, depending on user
> choice. And reading and writing in the same place is the only thing that
> can justify the 'adjust' in the name ;)


In fact you can change the date several time. When the dialog comes up the 
second time you want to change, the previous changes are already preset. Just 
change the date even more and it will be retained in mdate.

Gerhard

Created attachment 12205 [details]
Patch to extract digikam datetime from kipiplugins

digikam doesn't override the base libkipi function for datetime of an image
(which reverts to using the file modification time). This patch adds the
function.

On Saturday 13 August 2005 13:57, Gerhard Kulzer wrote:
> In fact you can change the date several time. When the dialog comes up the
> second time you want to change, the previous changes are already preset.
> Just change the date even more and it will be retained in mdate.


That is kind of nonsense. I can't add some days, and then subtract some hours 
for example. Because there is no adjustment, as long as the data isn't 
written back to where it was read. So I need a time calculator.

On a side note, the plugin should provide a list of the modifications it will 
do to each file, like rename utilities does. The current plugin requires 
quite a bit of imagination from the user!

I just installed jhead, which allows me to modify EXIF data, and we all have 
means of modifying inode data, so i can use the plugin to finally adjust 
digikam's internal date to the exif one.

It would be easier if digikam would provide means for doing it all though ;)

Anders, my attached patch fixes the problem of the timeadjust plugin not being reusable again. 

Now, as to the question of EXIF date: the plugin doesn't say that it will modify EXIF date... you assumed that. From what I have seen digikam presents only one datetime to the user (yeah, yeah... i know that you can peek at the EXIF date in the properties dialog) and the timeadjust plugin adjusts that.

Oops, my fix for "slideshow plugin being disabled at startup" leaked into the patch I submitted. Sorry about that

On Saturday 13 August 2005 14:28, Owen Hirst wrote:
> Now, as to the question of EXIF date: the plugin doesn't say that it will
> modify EXIF date... you assumed that. From what I have seen digikam
> presents only one datetime to the user (yeah, yeah... i know that you can
> peek at the EXIF date in the properties dialog) and the timeadjust plugin
> adjusts that.


Your patch definately makes this work much more like expected, so thanks a 
lot. I suggest it be comitted to close this bug, and also fix the slidewhow 
problem which is cool as well :) 

Manipulating EXIF data is more like a wish - it appears that I have a lot of 
images with bad EXIF dates. 

SVN commit 449513 by toma:

Owen Hirst <n8rider@sbcglobal.net>  has provided a patch for KIPI Rename Images (part of the BatchProcesses Plugin). 

kipi part:
* Complete rewrite
* Use rename instead of copy
* Allow formatting of date string

digikam part:
* fixes the time and date adjustment not working 
* Update database entry when a file is renamed by a KIPI Plugin
* make slideshow available right after digikams start

This fixes the following bugs:
BUGS:110391,110659,110698,110575,99895,104032,105727,110508,104511

great work!



 M  +16 -0     graphics/digikam/digikam/albumdb.cpp  
 M  +8 -0      graphics/digikam/digikam/albumdb.h  
 M  +2 -0      graphics/digikam/digikam/digikamapp.cpp  
 M  +24 -10    graphics/digikam/digikam/kipiinterface.cpp  
 M  +1 -0      graphics/digikam/digikam/kipiinterface.h  
 _M            libs/kipi-plugins/batchprocessimages (directory)  
 M  +3 -2      libs/kipi-plugins/batchprocessimages/Makefile.am  
 M  +22 -1     libs/kipi-plugins/batchprocessimages/batchprocessimagesitem.cpp  
 M  +7 -0      libs/kipi-plugins/batchprocessimages/batchprocessimagesitem.h  
 M  +3 -3      libs/kipi-plugins/batchprocessimages/plugin_batchprocessimages.cpp  
 A             libs/kipi-plugins/batchprocessimages/renameimagesbase.ui  
 M  +45 -663   libs/kipi-plugins/batchprocessimages/renameimagesdialog.cpp  
 M  +44 -79    libs/kipi-plugins/batchprocessimages/renameimagesdialog.h  
 A             libs/kipi-plugins/batchprocessimages/renameimageswidget.cpp   [License: GPL]
 A             libs/kipi-plugins/batchprocessimages/renameimageswidget.h   [License: GPL]

On Monday 15 August 2005 22:17, Tom Albers wrote:
> great work!


You people rock! :-)