| Summary: | Enhanced selection, refactored histogram | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | gsasha |
| Component: | ImageEditor-Canvas | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | wishlist | CC: | caulier.gilles, lure |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.9.1 | |
| Sentry Crash Report: | |||
| Attachments: |
Patch against the Aug 9 SVN version
New version of the patch Now including the rect_controller |
||
|
Description
gsasha
2005-08-10 16:51:01 UTC
Created attachment 12167 [details]
Patch against the Aug 9 SVN version
Hello, Your patch is still incomplete. It is missing the histogram_renderer.[cpp/h] files Created attachment 12168 [details]
New version of the patch
Added a new attachment, this time including the missing files
Now it seems to be missing rect_controller.cpp/h :) Created attachment 12169 [details]
Now including the rect_controller
GRRR. Is there a way in SVN, like in CVS, to check for all unknown files?
-Point 1 : good sound... Implementation not yet checked ! -Point 2 : Take a care to use common ImageHistogram implementation. -Point 3 : Definitivly NO. You need to use a separate thread againsty GUI thread. If you want to compute an histogram from a very large image (8/10 MPix for example), image editor will be frozen. Always use Qthread in this case. You can use my ThreadedImageFilter implementation in libs/imagefilter for example. Note that Qt4 will simplify QThread management using signal and slots ! Qthread will be derived from QObject. -Point 4 : Add this mode to the common implementation, and updated all other histogram rendering accordingly. digiKam must be stay homogenous! I recommend you to remove temporally this implementation. -Point 5 : Good sound. In General (implementation just checked, not compiled): - In imageHistogram.cpp : no need to recreate histogram computation implementation with your ImageHistogramData class... You must use the current implementation like it's used by other digiKam/DigikamImagePlugins parts (try grep for more info). Take a care : The current histogram implementation is common to digiKam. If you want add more methods, patch current ImageHistogram implementation. - Don't forget to use Digikam namespace. - Never use std::cerr, use Kdebug instead. - In the future, digiKam will be support 16/bits/color/pixels image file format using a new embedded framework named DImage instead QImage/imlib2. It's important to use a common implementation about histogram computation. - Why not using my histogram widget to rendering histogram on image editor canvas ? It's a common object... - Don't forget to try your implementation with ShowFoto. Gilles -Point 1 : good sound... Implementation not yet checked ! -Point 2 : Take a care to use common ImageHistogram implementation. -Point 3 : Definitivly NO. You need to use a separate thread againsty GUI thread. If you want to compute an histogram from a very large image (8/10 MPix for example), image editor will be frozen. Always use Qthread in this case. You can use my ThreadedImageFilter implementation in libs/imagefilter for example. Note that Qt4 will simplify QThread management using signal and slots ! Qthread will be derived from QObject. -Point 4 : Add this mode to the common implementation, and updated all other histogram rendering accordingly. digiKam must be stay homogenous! I recommend you to remove temporally this implementation. -Point 5 : Good sound. In General (implementation just checked, not compiled): - In imageHistogram.cpp : no need to recreate histogram computation implementation with your ImageHistogramData class... You must use the current implementation like it's used by other digiKam/DigikamImagePlugins parts (try grep for more info). Take a care : The current histogram implementation is common to digiKam. If you want add more methods, patch current ImageHistogram implementation. - Don't forget to use Digikam namespace. - Never use std::cerr, use Kdebug instead. - In the future, digiKam will be support 16/bits/color/pixels image file format using a new embedded framework named DImage instead QImage/imlib2. It's important to use a common implementation about histogram computation. - Why not using my histogram widget to rendering histogram on image editor canvas ? It's a common object... - Don't forget to try your implementation with ShowFoto. Gilles Caulier interesting. I'll take a look at this too. SVN commit 627802 by lure: Remove View->Histogram (blended histogram) from Digikam Editor and Showfoto (histogram is now avalable in sidebar with more functionality) Move Full screen and Slideshow in the same group in View menu to match the same grouping used in toolbar. CCBUG: 110514 M +2 -4 showfoto/showfotoui.rc M +1 -536 utilities/imageeditor/canvas/canvas.cpp M +0 -19 utilities/imageeditor/canvas/canvas.h M +2 -5 utilities/imageeditor/editor/digikamimagewindowui.rc M +0 -41 utilities/imageeditor/editor/editorwindow.cpp M +0 -1 utilities/imageeditor/editor/editorwindow.h M +0 -3 utilities/imageeditor/editor/editorwindowprivate.h View->Histogram code was removed as Digikam has now full featured histogram in the sidebar. This makes this improvement obsolete. |