Bug 110249

Summary: packport of gcc4 fix from trunk to 3.4 branch?
Product: [Unmaintained] kghostview Reporter: Walter Meinl <wuno>
Component: generalAssignee: Luís Pedro Coelho <luis>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: gcc4 patches vor displayoptions.(h/cpp) from the trunk

Description Walter Meinl 2005-08-05 17:18:54 UTC 
Version:            (using KDE KDE 3.4.2)
Installed from:    Gentoo Packages
Compiler:          gcc-4.0.1 
OS:                Linux

I tried to compile the split ebuilds of kde-meta-3.4.2 and kdesdk-meta-3.4.2 from scratch on x86 using gcc-4.0.1, binutils-2.16.1 and glibc-2.3.5-20050722 on gentoo linux. The only package refusing to compile with gcc4 was kghostview contained in kdegraphics-3.4.2 see attachment. There is already a fix for kghostview for the trunk see
http://websvn.kde.org/trunk/KDE/kdegraphics/kghostview/displayoptions.h?rev=423531&r1=409203&r2=423531
http://websvn.kde.org/trunk/KDE/kdegraphics/kghostview/displayoptions.cpp?rev=423531&r1=420737&r2=423531
It is not the latest revision (that would probably lead to problems as kde4 is
in sight) however this compile fix didn't make its way into the 3.4 branch and is 
therefore not included in the kdegraphics-3.4.2 tarball.
Comment 1 Walter Meinl 2005-08-05 17:21:06 UTC 
Created attachment 12102 [details]
gcc4 patches vor displayoptions.(h/cpp) from the trunk
Comment 2 Thiago Macieira 2005-08-07 06:42:24 UTC 
SVN commit 443732 by thiago:

Removing the templated operator<<, as suggested by Walter Meinl. Thanks
for pointing out.

I hope to get some points with Dirk's gcc4 compile police :-)

BUG:110249


 M  +1 -1      displayoptions.cpp  
 M  +0 -6      displayoptions.h  


--- branches/KDE/3.4/kdegraphics/kghostview/displayoptions.cpp #443731:443732
@@ -56,7 +56,7 @@
 	res.setMagnification( args->getOption( "scale" ).toFloat() );
 	res.setPage( args->getOption( "page" ).toInt() - 1 ); // transform from 1-based into 0-based
 	//res._overridePageMedia = args->getOption( "paper" );
-	kdDebug(4500 ) << "Parsed options: " << res << endl;
+	kdDebug(4500 ) << "Parsed options: " << DisplayOptions::toString( res ) << endl;
 	return res;
 }
 
--- branches/KDE/3.4/kdegraphics/kghostview/displayoptions.h #443731:443732
@@ -109,10 +109,4 @@
 	setMagnification( 1.0 );
 }
 
-template <typename OutStream>
-OutStream& operator << ( OutStream& out, const DisplayOptions& obj ) {
-	out << DisplayOptions::toString( obj ).utf8().data();
-	return out;
-}
-
 #endif // DISPLAYOPTIONS_H