Bug 110115

Summary: Tagging with RMB incomplete
Product: [Applications] digikam Reporter: Carsten Niehaus <cniehaus>
Component: Tags-KeywordsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 7.6.0
Sentry Crash Report:
Attachments: RMB-Menu mockup to fix this bug

Description Carsten Niehaus 2005-08-03 19:05:28 UTC 
Version:            (using KDE Devel)
Installed from:    Compiled sources

If you have subcategories in your list of tags you can drag&drop a thumbnail on any category, the tag will be asigned.

Foo
 -> Bar
 -> Buff
 ---> Blah

For example, using drag and drop you could asign all of those four categories to a picture. 

Using the right mouse button-menu you can only select the last subcategorie, in the example, you could only tag with "Blah" or "Bar". This is unintuitive and should be fixed.
Comment 1 Carsten Niehaus 2005-08-03 20:09:31 UTC 
Created attachment 12069 [details]
RMB-Menu mockup to fix this bug

As you can see I am in the menu for the subcategorie "Pflanze". It has two
sub-cats: Moos and Kormophyta, Kormophyta has four sub-cats.
My idea is to add a "Add as tag" or "Assign as tag" at the top of the menu of
"Pflanze". 
I hope my not existing artistic qualities are good enough to make you
understand this :)
Comment 2 Joern Ahrens 2005-08-03 23:11:34 UTC 
SVN commit 442775 by jahrens:

CCBUG: 110115

 M  +13 -1     tagspopupmenu.cpp  


--- trunk/extragear/graphics/digikam/digikam/tagspopupmenu.cpp #442774:442775
@@ -141,6 +141,19 @@
     {
         popup->insertItem(m_addTagPix, i18n("Add new Tag..."),
                           ADDTAGID + album->id());
+        popup->insertSeparator();
+                
+        QPixmap pix = SyncJob::getTagThumbnail(album->icon(), KIcon::SizeSmall);
+        if ((m_mode == ASSIGN) && (m_assignedTags.contains(album->id())))
+        {
+            popup->insertItem(new TagsPopupCheckedMenuItem(popup, album->title(), pix),
+                              m_addToID + album->id());
+        }
+        else
+        {
+            popup->insertItem(pix, album->title(), m_addToID + album->id());
+        }                
+        
         if (album->firstChild())
         {
             popup->insertSeparator();
@@ -182,7 +195,6 @@
             }
             else
             {
-
                 popup->insertItem(pix, a->title(), m_addToID + a->id());
             }
         }
Comment 3 Joern Ahrens 2005-08-03 23:13:19 UTC 
I've forgot to close the bug...