Summary: | Quanta crashes on startup | ||
---|---|---|---|
Product: | [Unmaintained] quanta | Reporter: | Jure Repinc <jlp> |
Component: | general | Assignee: | András Manţia <amantia> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | patch for kde 3.5 svn branches |
Description
Jure Repinc
2005-08-01 01:33:03 UTC
I think that it's the recent add of accessKeysEnabled support in kdelibs/khtml/khtmlview.cpp http://websvn.kde.org/branches/KDE/3.5/kdelibs/khtml/khtmlview.cpp?rev=440572&r1=438982&r2=440572 It's look like there is no KHTMLFactory() created before, when the new KHTMLViewPrivate is created http://lxr.kde.org/source/KDE/kdelibs/khtml/khtmlview.cpp?v=3.5-branch#467 The KHTMLView is created there http://lxr.kde.org/source/KDE/kdewebdev/quanta/parts/kafka/kafkahtmlpart.cpp?v=3.5-branch#088 Created attachment 12149 [details]
patch for kde 3.5 svn branches
create the kpart, register the khtmlfactory and add the view
Thanks' for finding the problematic commit. I informed the KHTML developers about it. Unfortunately your fix is not good as it will not create the needed KHTMLView object... Andras On Tuesday 09 August 2005 10:31, Mantia Andras wrote:
> Unfortunately your fix is not good as it will not
> create the needed KHTMLView object...
Correction: the fix looks to be good as I missed that there is a second
constructor for KHTMLPart...
SVN commit 444206 by amantia: Workaround for the newly introduced KHTML bug (crashes when using the KHTMLPart constructor with KHTMLView argument or when creating a KHTMLView alone). Patch by Yan Morin. BUG: 109962 M +1 -1 parts/kafka/kafkahtmlpart.cpp M +7 -7 quanta.kdevelop --- branches/KDE/3.5/kdewebdev/quanta/parts/kafka/kafkahtmlpart.cpp #444205:444206 @@ -85,7 +85,7 @@ KafkaWidget::KafkaWidget(QWidget *parent, QWidget *widgetParent, KafkaDocument *part, const char *name) - : KHTMLPart(new KHTMLView(this, widgetParent, name), parent, name), + : KHTMLPart(widgetParent, name, parent, name), w(part) { m_contextPopupMenu = new QPopupMenu(); --- branches/KDE/3.5/kdewebdev/quanta/quanta.kdevelop #444205:444206 @@ -33,7 +33,7 @@ <abortonerror>true</abortonerror> <numberofjobs>2</numberofjobs> <dontact>false</dontact> - <makebin></makebin> + <makebin/> <envvars> <envvar value="no" name="UNSERMAKE" /> <envvar value="1" name="WANT_AUTOCONF_2_5" /> @@ -191,16 +191,16 @@ </kdevdoctreeview> <kdevdebugger> <general> - <dbgshell></dbgshell> - <programargs></programargs> + <dbgshell/> + <programargs/> <gdbpath>/usr/bin/</gdbpath> <breakonloadinglibs>true</breakonloadinglibs> <separatetty>false</separatetty> <floatingtoolbar>false</floatingtoolbar> <runappinappdirectory>true</runappinappdirectory> - <configGdbScript></configGdbScript> - <runShellScript></runShellScript> - <runGdbScript></runGdbScript> + <configGdbScript/> + <runShellScript/> + <runGdbScript/> </general> <display> <staticmembers>false</staticmembers> @@ -271,7 +271,7 @@ <pcs>KDElibs</pcs> </references> <creategettersetter> - <prefixGet></prefixGet> + <prefixGet/> <prefixSet>set</prefixSet> <prefixVariable>m_,_</prefixVariable> <parameterName>theValue</parameterName> |