Bug 109822

Summary:	[PATCH] turning off "Show events in chat window" should stop kopete internal messages too
Product:	[Unmaintained] kopete	Reporter:	Sven-Erik Petermann <sverik>
Component:	Chat Window	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	tpr
Priority:	NOR
Version First Reported In:	0.40.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch for bug 109822

Description Sven-Erik Petermann 2005-07-29 11:05:04 UTC

Version:           0.10.2 (using KDE KDE 3.4.1)
Installed from:    Fedora RPMs
OS:                Linux

Unchecking the "Show events in chat window" checkbox should disable messages like: "-- Peter has left the chat." in chat window. Kopete help also says how it should be:
"Show events in chat window
Some IM systems can give extra information, like people joining or leaving chats. This option lets you receive these messages in your chat window."
However, disabling the option won't stop messages like "... has left the chat" from appearing.

Comment 1 Matt Rogers 2005-07-30 04:53:15 UTC

that's because an IM system doesn't generate those events, we do.

Comment 2 step247 2005-12-21 10:57:21 UTC

"has left the chat" message is one of the most annoying "features" in kopete. 

I did disable the "Enable events for active chat window", restarted the Kopete but   it did not stop the  "has left the chat" messages. (MSN)

Comment 3 Jaak Simm 2005-12-21 13:42:02 UTC

I agree.
This is especially true for MSN protocol, where there is officially no such event as "has left the chat" for 2-person conversations. Of course "officially" here means that the MSN Messenger does not show such events to the user, when only two people are having a conversation, they are only shown when 3 or more people are chatting simultaneously.

Comment 4 Jason Keirstead 2005-12-23 16:21:17 UTC

*** This bug has been confirmed by popular vote. ***

Comment 5 Sven-Erik Petermann 2006-02-01 18:51:05 UTC

Just created a simple fix for the devel version. Added
&& KopetePrefs::prefs()->showEvents()
to the if responsible for checkig whether to show these messages. I will upload a patch soon.

Comment 6 Sven-Erik Petermann 2006-02-01 19:44:18 UTC

Created attachment 14483 [details]
Patch for bug 109822

A patch for
kdenetwork/kopete/kopete/chatwindow/chatview.cpp

Comment 7 Teemu Rytilahti 2010-07-28 16:41:01 UTC

Odd that this hasn't ever been commited. Got tired of this and made a patch, will commit when approved. See http://reviewboard.kde.org/r/4768/

Comment 8 Teemu Rytilahti 2010-07-28 17:18:41 UTC

SVN commit 1156102 by rytilahti:

Don't show joins&quits in chatwindow, if user has decided not to show events

BUGS:109822


 M  +2 -2      chatview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1156102

Comment 9 Teemu Rytilahti 2010-08-18 20:33:43 UTC

SVN commit 1165283 by rytilahti:

backport r1156102:

Don't show joins&quits in chatwindow, if user has decided not to show events

CCBUG:109822



 M  +2 -2      chatview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1165283