Bug 109217

Summary:	kfmclient doesn't accept web shortcuts with space as separator
Product:	[Applications] konqueror	Reporter:	Christoph Lange <langec>
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	finex
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:	4.6.5
Sentry Crash Report:

Description Christoph Lange 2005-07-17 15:58:26 UTC

Version:            (using KDE KDE 3.4.1)
Installed from:    Gentoo Packages
Compiler:          i686-pc-linux-gnu-3.3.5-20050130 
OS:                Linux

When the separator character for web shortcuts is set to a space, kfmclient openURL won't recognize addresses with a shortcut (for example "gg Google") correctly. Instead, they are interpreted as filenames. kfmclient works when the separator is set to a colon.

Comment 1 Philip Rodrigues 2006-09-05 20:22:28 UTC

Same on 3.5 branch r575787. I suppose this is because kfmclient has no way of knowing if "gg searchterm" is intended as a filename or a web shortcut. Possibilities: 
* search through the web shortcuts; if the first word of the URL matches, interpret as a web shortcut (not a file). 
* have a separate command that recognises web shortcuts (instead of openURL)?

Neither sounds particularly appealing though

Comment 2 techo 2008-05-18 13:34:15 UTC

Can confirm this on 3.5.9.

On 4.0.74 svn trunk r808533 (qt4.4 final) "kfmclient openURL gg google" crashes:
kfmclient openURL gg fads

backtrace:
Application: Konqueror (konqueror), signal SIGABRT
[Thread debugging using libthread_db enabled]
[New Thread 0xb61aa940 (LWP 9425)]
[KCrash handler]
#6  0xb7fb7410 in __kernel_vsyscall ()
#7  0xb6503085 in raise () from /lib/tls/i686/cmov/libc.so.6
#8  0xb6504a01 in abort () from /lib/tls/i686/cmov/libc.so.6
#9  0xb70ff795 in qt_message_output (msgType=QtFatalMsg, 
    buf=0xbff3b530 "ASSERT: \"d\" in file /home/ecki/kde/kde4/include/ksharedptr.h, line 116") at global/qglobal.cpp:2058
#10 0xb70ff819 in qFatal (msg=0xb7255e58 "ASSERT: \"%s\" in file %s, line %d")
    at global/qglobal.cpp:2260
#11 0xb70ffc71 in qt_assert (assertion=0xb7f9e6b5 "d", 
    file=0xb7f9e68c "/home/ecki/kde/kde4/include/ksharedptr.h", line=116)
    at global/qglobal.cpp:1828
#12 0xb7f1570b in KSharedPtr<KMimeType>::operator-> (this=0xbff3d5dc)
    at /home/ecki/kde/kde4/include/ksharedptr.h:116
#13 0xb7f7fcd2 in KonqFMSettings::shouldEmbed (this=0x814e998, 
    mimeType=@0xbff3d864)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqsettings.cpp:109
#14 0xb7f6634a in KonqMainWindow::openView (this=0x8153988, 
    mimeType=@0xbff3d864, _url=@0xbff3db40, childView=0x81419a8, 
    req=@0xbff3d80c)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqmainwindow.cpp:756
#15 0xb7f675cb in KonqMainWindow::makeViewsFollow (this=0x8153988, 
    url=@0xbff3db40, args=@0xbff3dc78, browserArgs=@0xbff3dc7c, 
    serviceType=@0xbff3db8c, senderView=0x8292c60)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqmainwindow.cpp:1063
#16 0xb7f65e34 in KonqMainWindow::openView (this=0x8153988, 
    mimeType=@0xbff3db8c, _url=@0xbff3db40, childView=0x8292c60, 
    req=@0xbff3dc68)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqmainwindow.cpp:696
#17 0xb7f68b0b in KonqMainWindow::openUrl (this=0x8153988, _view=0x8292c60, 
    _url=@0xbff3df48, _mimeType=@0xbff3dcc0, req=@0xbff3dc68, 
    trustedSource=false)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqmainwindow.cpp:581
#18 0xb7f25cdf in KonqViewManager::loadViewProfileFromGroup (this=0x814fe08, 
    profileGroup=@0xbff3dd0c, filename=@0xbff3de70, forcedUrl=@0xbff3df48, 
    req=@0xbff3dd64, openUrl=true)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqviewmanager.cpp:937
#19 0xb7f25ea3 in KonqViewManager::loadViewProfileFromConfig (this=0x814fe08, 
    _cfg=@0xbff3ddcc, path=@0xbff3de64, filename=@0xbff3de70, 
    forcedUrl=@0xbff3df48, req=@0xbff3dd64, resetWindow=false, openUrl=true)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqviewmanager.cpp:886
#20 0xb7f2d2b0 in KonqMisc::createBrowserWindowFromProfile (path=@0xbff3de64, 
    filename=@0xbff3de70, url=@0xbff3df48, args=@0xbff3e084, 
    browserArgs=@0xbff3def4, forbidUseHTML=false, filesToSelect=@0xbff3e098, 
    tempFile=false, openUrl=true)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqmisc.cpp:144
#21 0xb7f2d598 in KonqMisc::createNewWindow (url=@0xbff3df48, 
    args=@0xbff3e084, browserArgs=@0xbff3def4, forbidUseHTML=false, 
    filesToSelect=@0xbff3e098, tempFile=false, openUrl=true)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqmisc.cpp:101
#22 0xb7f9cfcb in kdemain (argc=4, argv=0xbff3e2f4)
    at /home/ecki/kde/src/kdebase/apps/konqueror/src/konqmain.cpp:221
#23 0x08048786 in main (argc=)
    at /home/ecki/kde/build/kdebase/apps/konqueror/src/konqueror_dummy.cpp:3
#0  0xb7fb7410 in __kernel_vsyscall ()

Comment 3 FiNeX 2009-02-01 00:55:27 UTC

Similar to bug #182449

Comment 4 Dawit Alemayehu 2011-06-22 22:51:57 UTC

Git commit c41f59b017d9ca24f899fc5727a9a6070084351f by Dawit Alemayehu.
Committed on 14/06/2011 at 00:16.
Pushed by adawit into branch 'KDE/4.6'.

Use KUriFilter to filter user input so that web shortcuts and short uris
work properly.

BUG: 109217
FIXED-IN: 4.6.5
REVIEW: 101625

M  +18   -3    konqueror/client/kfmclient.cpp     

http://commits.kde.org/kde-baseapps/c41f59b017d9ca24f899fc5727a9a6070084351f

Comment 5 Dawit Alemayehu 2011-06-22 23:26:10 UTC

Git commit 9dc77054f75eae7ae1f34de731717b6f1248ddc6 by Dawit Alemayehu.
Committed on 14/06/2011 at 00:16.
Pushed by adawit into branch 'KDE/4.7'.

Use KUriFilter to filter user input so that web shortcuts and short uris
work properly.

BUG: 109217
FIXED-IN: 4.6.5
REVIEW: 101625

M  +18   -3    konqueror/client/kfmclient.cpp     

http://commits.kde.org/kde-baseapps/9dc77054f75eae7ae1f34de731717b6f1248ddc6

Comment 6 Dawit Alemayehu 2011-06-22 23:33:23 UTC

Git commit 7ac1544e33ed242068b8e2f87fefe5ebb0407e3b by Dawit Alemayehu.
Committed on 14/06/2011 at 00:16.
Pushed by adawit into branch 'master'.

Use KUriFilter to filter user input so that web shortcuts and short uris
work properly.

BUG: 109217
FIXED-IN: 4.6.5
REVIEW: 101625

(cherry picked from commit 9dc77054f75eae7ae1f34de731717b6f1248ddc6)

M  +18   -3    konqueror/client/kfmclient.cpp     

http://commits.kde.org/kde-baseapps/7ac1544e33ed242068b8e2f87fefe5ebb0407e3b