Bug 109003

Summary: kmail saves attachments with size 0
Product: [Unmaintained] kmail Reporter: Ferdinand Gassauer <gassauer>
Component: generalAssignee: kdepim bugs <pim-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 1.8.50   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Ferdinand Gassauer 2005-07-12 21:39:31 UTC 
Version:           1.8.50 (using KDE 3.4.89 (>= 20050615), compiled sources)
Compiler:          gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)
OS:                Linux (i686) release 2.6.11.4-21.7-smp

Hi!
For some days now it is not possible any more to open and save attachments due to size 0.

after some navigation back and fore between folders it is sometime possible to save the attachment. ( I know you'll like this ).

the source is IMAP an "load on demand" is "on".
Comment 1 Carsten Burghardt 2005-07-14 14:32:40 UTC 
Confirmed, somebody broke that. The readerwin doesn't find the partNode anymore.
Comment 2 David Faure 2005-07-15 17:50:46 UTC 
Could this be due to the mimelib fix (where I changed a const char* into a DWString?)
Carsten, can you double-check the code which uses the part ID?
Comment 3 Carsten Burghardt 2005-07-23 13:46:20 UTC 
SVN commit 437867 by burghard:

Compare the IDs correctly with kasciistricmp.
BUGS:109003


 M  +2 -1      partNode.cpp  


--- trunk/KDE/kdepim/kmail/partNode.cpp #437866:437867
@@ -36,6 +36,7 @@
 #include "kmmimeparttree.h"
 #include <mimelib/utility.h>
 #include <qregexp.h>
+#include <kasciistricmp.h>
 
 /*
   ===========================================================================
@@ -413,7 +414,7 @@
 partNode* partNode::findNodeForDwPart( DwBodyPart* part )
 {
     partNode* found = 0;
-    if( dwPart()->partId() == part->partId() )
+    if( kasciistricmp( dwPart()->partId(), part->partId() ) == 0 )
         return this;
     if( mChild )
         found = mChild->findNodeForDwPart( part );
Comment 4 Michael Nottebrock 2005-08-02 02:59:47 UTC 
The kmail shipped in KDE 3.4.2 is affected by this bug.
Comment 5 Carsten Burghardt 2005-08-03 11:54:47 UTC 
See 109933