| Summary: | please support UPnP in KTorrent | ||
|---|---|---|---|
| Product: | [Applications] ktorrent | Reporter: | Alexander van Loon <a.vanloon> |
| Component: | general | Assignee: | Joris Guisson <joris.guisson> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | joris.guisson, kdebugs, thiago |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Alexander van Loon
2005-07-11 17:35:22 UTC
I don't have a router, so this could be difficult. Joris: are you using the socket classes in kdelibs/kdecore/network (the KNetwork classes)? Nope, QSocket. Do these classes support UPnP ? No, and they never will. If you use KNetwork, you could assign this bug to me, since UPnP support is part of my to-do list. By the way, QSocket is forbidden to KDE applications. You have to use KNetwork. When I looked at KNetwork, the documentation was not very clear, the service parameter (for example in the constructor of KStreamSocket) wasn't well explained. From the examples I can now make out that I can just fill in the port (converted to a string). That wasn't very clear back then. So I just went for QSocket. You should really add some more documentation (Just say service can be a port number or one of the following strings, followed by a list of strings) I'll switch to KNetwork. As for assigning this to you, will your implementation require no changes (apart from the KNetwork one) for ktorrent ? My idea is that you won't require any special code on the app side. Everything should be handled by the library. Service is the port name (i.e., "http" or "80"). You get the bug
Another question, with KStreamSocket can the node parameter (the hostname) be an IP address ?
Is this valid :
KStreamSocket("123.123.123.123","6666")
Joris Guisson wrote: >Another question, with KStreamSocket can the node parameter (the > hostname) be an IP address ? > >Is this valid : >KStreamSocket("123.123.123.123","6666") Yes. Thiago, Hi, I just stumbled upon this bug. What's your current status on upnp? I ask because I have a primative (it purely supports hunting for routers and making nat holes) UPnP class working that I was going to incorporate into konversation for dcc support. I hadn't realised that anyone else was working on this. Well, I'm interested in this class of yours as a temporary solution, it will probably take a while before this is implemented in KDE. And seeing that I'm not planning on switching to KNetwork until after the 1.1 release, UPnP support is at least 3 or 4 months away for KTorrent. Well, seeing as I don't have any time to code this (I haven't started yet) and it's not in the feature list for KDE 3.5, I think we'd all benefit from your class. I'll later move it upstream to KNetwork, for KDE 4. Seeing that I'm working on my own implementation, I'm gonna take over this wish. *** Bug 110763 has been marked as a duplicate of this bug. *** SVN commit 480193 by guisson: Added UPnP plugin to ktorrent BUG: 108930 M +1 -1 ktorrent.kdevelop M +4 -4 libktorrent/util/Makefile.am A libktorrent/util/httprequest.cpp [License: GPL (v2+) (wrong address)] A libktorrent/util/httprequest.h [License: GPL (v2+) (wrong address)] M +1 -1 plugins/upnp/soap.cpp M +8 -0 plugins/upnp/upnpmcastsocket.cpp M +1 -0 plugins/upnp/upnpmcastsocket.h M +0 -4 plugins/upnp/upnpplugin.cpp M +18 -13 plugins/upnp/upnpprefwidget.cpp M +1 -4 plugins/upnp/upnpprefwidget.h M +43 -117 plugins/upnp/upnprouter.cpp M +15 -22 plugins/upnp/upnprouter.h Thank you so much Joris :). It's been some time ago since I posted this bugreport, in the meanwhile I switched from KDE to GNOME 2.12 on Ubuntu Breezy, I like GNOME 2.12 more than KDE atm. But when the next Kubuntu release is out, I'll make sure to check KTorrent out again. You're doing a great job, and it's awesome that there finally is a good Bittorrent client for KDE with advanced features like UPnP. |