Bug 108876

Summary:	If I drag a song in the playlist to the "Filter here..." text area the "Filter here..." text stays underneath the text
Product:	[Applications] amarok	Reporter:	Brian Beck <brian.beck>
Component:	general	Assignee:	Arissa Seah <arissaseah51>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arissaseah51
Priority:	NOR
Version First Reported In:	1.2.4
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
URL:	https://www.mercuryconsulting.biz/greece-golden-visa/
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Before the drag to the "Filter here..." text area After the drag to the "Filter here..." text area Zoom in on the text area

Description Brian Beck 2005-07-10 21:18:03 UTC

Version:           1.2.4 (using KDE KDE 3.3.2)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc (GCC) 3.3.6 (Debian 1:3.3.6-7) 
OS:                Linux

If I drag a song from the playlist up to the "Filter here..." text area the gray "Filter here..." text stays underneath the file url that appears in the text area.

If this is an old bug I'm sorry for wasting your time.

Thanks.

Comment 1 Brian Beck 2005-07-10 21:23:46 UTC

Created attachment 11746 [details]
Before the drag to the "Filter here..." text area

Comment 2 Brian Beck 2005-07-10 21:24:21 UTC

Created attachment 11747 [details]
After the drag to the "Filter here..." text area

Comment 3 Brian Beck 2005-07-10 21:24:49 UTC

Created attachment 11748 [details]
Zoom in on the text area

Comment 4 Seb Ruiz 2005-09-22 16:52:39 UTC

Yes, i've seen this.

Comment 5 Seb Ruiz 2006-01-02 07:28:45 UTC

SVN commit 493307 by seb:

Don't show 'Filter Here...' text after dropping text onto a filter line edit
BUG: 108876


 M  +2 -0      ChangeLog  
 M  +8 -0      src/clicklineedit.cpp  
 M  +1 -0      src/clicklineedit.h  


--- trunk/extragear/multimedia/amarok/ChangeLog #493306:493307
@@ -76,6 +76,8 @@
       compatibility with various iPod models.
 
   BUGFIXES:
+    * Dragging text to a filter line edit would still show the "Filter
+      Here..." text in the background. (BR 108876)
     * Don't show an empty playlist length holder in the statusbar.
     * Allow for % and _ in tags, and filter them correctly.
     * Do not copy files of types an iPod is not capable of playing to the
--- trunk/extragear/multimedia/amarok/src/clicklineedit.cpp #493306:493307
@@ -75,7 +75,15 @@
     }
 }
 
+void ClickLineEdit::dropEvent( QDropEvent *ev )
+{
+    mDrawClickMsg = false;
+    repaint();
 
+    KLineEdit::dropEvent( ev );
+}
+
+
 void ClickLineEdit::focusInEvent( QFocusEvent *ev )
 {
     if ( mDrawClickMsg == true ) {
--- trunk/extragear/multimedia/amarok/src/clicklineedit.h #493306:493307
@@ -44,6 +44,7 @@
 
     protected:
         virtual void drawContents( QPainter *p );
+        virtual void dropEvent( QDropEvent *ev );
         virtual void focusInEvent( QFocusEvent *ev );
         virtual void focusOutEvent( QFocusEvent *ev );