Summary: | slideshow interval below 1 second | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Benjamin Schallar <benjamin.dev> |
Component: | Plugin-Generic-Presentation | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.1.0 | |
Sentry Crash Report: |
Description
Benjamin Schallar
2005-06-26 04:27:35 UTC
I think I found what I was looking for: slideshow.cpp, line 106: "delay_ = QMAX(delay, 300); // at least have 0.3 second delay" slideshow.cpp, line 172: "delaySpinBox_ = new QSpinBox( 1000, 10000, 10, page );" slideshowgl.cpp, line 96: "delay_ = QMAX(delay, 1000); // at least have 1 second delay" Although this might be a solution, I will test my changes first and try contacting the authors why they inserted those "qmax" values (I'm sure there must've been a reason for this.) Testing and emails after I got some sleep... Regards, Benjamin As far as I can tell, it works fine for the "normal" (i.e. non-openGL) slideshow, but doesn't work out (at least with my radeon mobility 7500) using the openGL slideshow. So my patch (which I currently only tried using [0] with the packages from [1], see [2] for more on that) will only include the following changes: slideshow.cpp, line 106: - "delay_ = QMAX(delay, 300); // at least have 0.3 second delay" + "delay_ = QMAX(delay, 100); // at least have 0.1 second delay" slideshow.cpp, line 172: - "delaySpinBox_ = new QSpinBox( 1000, 10000, 10, page );" + "delaySpinBox_ = new QSpinBox( 100, 10000, 10, page );" Anything below 1/10th second eludes my rationale, but I will test it and post results for that here as well, although it won't be included in my proposed patch. Regards, Benjamin [0] http://familiasanchez.net/~sanchezr/?page=debcustomize [1] http://pkg-kde.alioth.debian.org/kde-3.4.1/ [2] http://pkg-kde.alioth.debian.org/docs/ SVN commit 613541 by vfuoglio: Now slideshow interval can be set below 1000 ms (min 100 ms). CCMAIL: kde-imaging@kde.org BUG: 108147 M +4 -1 slideshowconfigbase.ui --- trunk/extragear/libs/kipi-plugins/slideshow/slideshowconfigbase.ui #613540:613541 @@ -511,11 +511,14 @@ <number>10000</number> </property> <property name="minValue"> - <number>1000</number> + <number>100</number> </property> <property name="lineStep"> <number>10</number> </property> + <property name="value"> + <number>1000</number> + </property> </widget> </hbox> </widget> Valerio, please unforget to put your B.K.O file title fixed into NEWS file list to simplify future release announces. Thanks in advance... Gilles Thanks Gilles, I will take care. :) Valerio Thanks for fixing! :-) |