Bug 107283

Summary: kaddprinterwizard settings button is not active
Product: [Unmaintained] kdeprint Reporter: FiNeX <finex>
Component: generalAssignee: KDEPrint Devel Mailinglist <kde-print-bugs-null>
Status: CLOSED FIXED    
Severity: normal CC: jlayt
Priority: NOR    
Version First Reported In: 3.4.1   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description FiNeX 2005-06-12 18:05:28 UTC 
Version:           3.4.1 (using KDE KDE 3.4.1)
Installed from:    Compiled From Sources
Compiler:          gcc 3.3.5 
OS:                Linux

kaddprinterwizard settings button during the wizard procedure (near "test" button) is not active when clicking back button from the "banner selection" page of the wizard.
Comment 1 Cristian Tibirna 2005-09-29 05:03:04 UTC 
SVN commit 465077 by tibirna:

Don't loose driver information on "Back".
Thanks to Michael Goffioul for hints.
BUG:107283


 M  +1 -0      kmwdrivertest.cpp  
 M  +1 -1      kmwizard.cpp  
 M  +1 -0      kmwizardpage.cpp  
 M  +2 -0      kmwizardpage.h  


--- branches/KDE/3.5/kdelibs/kdeprint/management/kmwdrivertest.cpp #465076:465077
@@ -40,6 +40,7 @@
 	m_ID = KMWizard::DriverTest;
 	m_title = i18n("Printer Test");
 	m_nextpage = KMWizard::Name;
+        m_needsinitonback = true;
 	m_driver = 0;
 	m_printer = 0;
 
--- branches/KDE/3.5/kdelibs/kdeprint/management/kmwizard.cpp #465076:465077
@@ -198,7 +198,7 @@
 	// raise page + initialize
 	m_stack->raiseWidget(page);
 	m_title->setText(page->title());
-	if (!back) page->initPrinter(m_printer);
+	if (!back || page->needsInitOnBack()) page->initPrinter(m_printer);
 
 	// update buttons
 	if (ID == m_start) m_prev->setEnabled(false);
--- branches/KDE/3.5/kdelibs/kdeprint/management/kmwizardpage.cpp #465076:465077
@@ -26,6 +26,7 @@
 	m_ID = KMWizard::Error;
 	m_title = "KMWizardPage";
 	m_nextpage = KMWizard::Error;
+        m_needsinitonback = false;
 }
 
 KMWizardPage::~KMWizardPage()
--- branches/KDE/3.5/kdelibs/kdeprint/management/kmwizardpage.h #465076:465077
@@ -40,11 +40,13 @@
 	virtual bool isValid(QString&);
 	virtual void initPrinter(KMPrinter*);
 	virtual void updatePrinter(KMPrinter*);
+        bool needsInitOnBack()          { return m_needsinitonback; }
 
 protected:
 	QString	m_title;
 	int	m_ID;
 	int	m_nextpage;
+        bool    m_needsinitonback;
 };
 
 #endif
Comment 2 John Layt 2008-12-31 18:39:38 UTC 
Closing old Resolved status bug.